[sqlite] custom sqlite and sqlcipher #30824
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
expo-bot
added
the
bot: needs changes
|
The Pull Request introduced fingerprint changes against the base commit: dea2ae0 Fingerprint diff[
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-sqlite/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "ad80ae03660f3a20cba5a2be1b6d6fc059993937"
}
},
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-sqlite/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "68771f69ca4bd94990e69d5a2f38fcc584816689"
}
}
]Generated by PR labeler 🤖 |
Kudo
changed the title
|
|
||
| int crsqlite_init_from_swift(sqlite3 *db) { | ||
| sqlite3_enable_load_extension(db, 1); | ||
| exsqlite3_enable_load_extension(db, 1); |
There was a problem hiding this comment.
This reminds me. We should remove crsqlite. It's no longer maintained. Matt has moved on to other things
There was a problem hiding this comment.
yes, we've talked this with Brent. we would remove it from sdk 53 and give a deprecated warning in sdk 52
https://linear.app/expo/issue/ENG-12984/deprecate-enablecrsqlite-and-warn-when-used
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇 ❌ Error: Forbidden file size or format
Generated by ExpoBot 🤖 against 7bd33ae |
# Why we forced to use third-party sqlite in expo-updates because #24375. it caused ios build issue like #30546 if lib uses system sqlite. with #30824, the third-party sqlite is not necessary anymore. close ENG-12866 # How rollback to use system sqlite by default but still provides a configurable `expo.updates.use3rdPartySQLitePod` for **ios/Podfile.properties.json** to change it.
Why
close ENG-11976
close ENG-12401
How
sqlite3_*api asexsqlite3_*../configureon windows to sqlite3.c building. publishing npm would be easier.the scripts/prepare_sqlite.ts is for downloading sqlite and sqlcipher. the scripts/replace_symbols.ts is to replace
exsqlite3_in both sqlite, sqlcipher and our source code. both these scripts are for maintenance when we need to upgrade sqlite version.the expo-sqlite tarball size will increase from 2.9MB to 7.7MB
Test Plan
expo.sqlite.enableFTSto **ios/Podfile.properties.json` / android/gradle.properties to bare-expo for testing.Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).