chore: add more tests for entity loader #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
force-pushed
the
@wschurman/can-delete-4
branch
from
1ec850f to
fc39c3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 98.10% 99.41% +1.31%
==========================================
Files 68 69 +1
Lines 1846 1887 +41
Branches 249 263 +14
==========================================
+ Hits 1811 1876 +65
+ Misses 33 11 -22
+ Partials 2 0 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wschurman
force-pushed
the
@wschurman/can-delete-4
branch
from
fc39c3c to
7132beb
Compare
wschurman
force-pushed
the
@wschurman/can-delete-3
branch
from
20fb26a to
4fe15ef
Compare
wschurman
force-pushed
the
@wschurman/can-delete-4
branch
from
7132beb to
4ff2611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Similar to #228, there was some missing coverage for the loader. This completes the coverage.
How
Add tests.
Test Plan
Run tests, verify coverage.