Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more tests for privacy policy rules and nested transaction query contexts #228

Merged
merged 1 commit into from
May 30, 2024

Conversation

wschurman
Copy link
Member

Why

Noticed that the test coverage of this was missing. Similar to #227, this was easy enough to add some coverage for (and it's important to have tests for this).

How

Add tests.

Test Plan

Run tests.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (8a448b5) to head (20fb26a).
Report is 1 commits behind head on main.

Current head 20fb26a differs from pull request most recent head 4fe15ef

Please upload reports for the commit 4fe15ef to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   98.10%   98.78%   +0.68%     
==========================================
  Files          68       69       +1     
  Lines        1846     1899      +53     
  Branches      249      266      +17     
==========================================
+ Hits         1811     1876      +65     
+ Misses         33       22      -11     
+ Partials        2        1       -1     
Flag Coverage Δ
integration 98.78% <100.00%> (+0.68%) ⬆️
unittest 98.78% <100.00%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman wschurman force-pushed the @wschurman/can-delete-2 branch from ff5c244 to 0e991ca Compare May 30, 2024 17:08
Base automatically changed from @wschurman/can-delete-2 to main May 30, 2024 17:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
… query contexts
@wschurman wschurman force-pushed the @wschurman/can-delete-3 branch from 20fb26a to 4fe15ef Compare May 30, 2024 17:09
@wschurman wschurman merged commit 428cc6f into main May 30, 2024
1 check passed
@wschurman wschurman deleted the @wschurman/can-delete-3 branch May 30, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant