-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] improve fingerprint UX #2675
Conversation
Subscribed to pull request
Generated by CodeMention |
Size Change: +656 B (0%) Total Size: 52.9 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
==========================================
- Coverage 52.97% 52.94% -0.03%
==========================================
Files 576 576
Lines 22084 22101 +17
Branches 4334 4335 +1
==========================================
+ Hits 11697 11699 +2
- Misses 10353 10368 +15
Partials 34 34 ☔ View full report in Codecov by Sentry. |
if (options.debug) { | ||
fingerprintOptions.debug = true; | ||
} | ||
const fingerprint = await Fingerprint.createFingerprintAsync(projectDir, fingerprintOptions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot this when I was reviewing the other PR re: doing a function call directly vs CLI call. One additional consideration/benefit of CLI is the process/subprocess model of using the CLI via spawn instead of a direct function call. By having this be in a subprocess rather than the CLI process, we could monitor that and even kill it with a Promise.race
if it's taking too long (I think?).
1e18121
to
6402f90
Compare
✅ Thank you for adding the changelog entry! |
Why
This PR does the following:
EAS_SKIP_AUTO_FINGERPRINT
is set, as per https://www.notion.so/expo/Soft-fingerprinting-116e5b5735248071951cddcab32ae43d?pvs=4#116e5b57352480e89189eb7feb88dacdHow
Test Plan
eas build
with and withoutEAS_SKIP_AUTO_FINGERPRINT=1