[eas-cli] improve fingerprint UX (#2675)

* [eas-cli] improve UX and slow fingerprint logs * [eas-cli] env var to skip fingerprint computation * pr feedback * Update packages/eas-cli/src/utils/fingerprintCli.ts Co-authored-by: Will Schurman <[email protected]> * Temporary Commit at 11/8/2024, 3:17:40 PM --------- Co-authored-by: Will Schurman <[email protected]>
expo · Nov 9, 2024 · 027d362 · 027d362
1 parent c30c1cd
commit 027d362
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,8 @@ This is the log of notable changes to EAS CLI and related packages.
 
 ### 🎉 New features
 
+- Add EAS_SKIP_AUTO_FINGERPRINT to skip fingerprint computation on build ([#2675](https://github.com/expo/eas-cli/pull/2675) by [@quinlanj](https://github.com/quinlanj))
+
 ### 🐛 Bug fixes
 
 ### 🧹 Chores

diff --git a/packages/eas-cli/src/utils/fingerprintCli.ts b/packages/eas-cli/src/utils/fingerprintCli.ts
@@ -1,6 +1,9 @@
 import { Env, Workflow } from '@expo/eas-build-job';
 import { silent as silentResolveFrom } from 'resolve-from';
 
+import Log from '../log';
+import { ora } from '../ora';
+
 export async function createFingerprintAsync(
   projectDir: string,
   options: {
@@ -20,17 +23,40 @@ export async function createFingerprintAsync(
   if (!fingerprintPath) {
     return null;
   }
-  const Fingerprint = require(fingerprintPath);
-  const fingerprintOptions: Record<string, any> = {};
-  if (options.platform) {
-    fingerprintOptions.platforms = [options.platform];
-  }
-  if (options.workflow === Workflow.MANAGED) {
-    fingerprintOptions.ignorePaths = ['android/**/*', 'ios/**/*'];
+
+  if (process.env.EAS_SKIP_AUTO_FINGERPRINT) {
+    Log.log('Skipping project fingerprint');
+    return null;
   }
-  if (options.debug) {
-    fingerprintOptions.debug = true;
+
+  const timeoutId = setTimeout(() => {
+    Log.log('⌛️ Computing the project fingerprint is taking longer than expected...');
+    Log.log('⏩ To skip this step, set the environment variable: EAS_SKIP_AUTO_FINGERPRINT=1');
+  }, 5000);
+
+  const spinner = ora(`Computing project fingerprint`).start();
+  try {
+    const Fingerprint = require(fingerprintPath);
+    const fingerprintOptions: Record<string, any> = {};
+    if (options.platform) {
+      fingerprintOptions.platforms = [options.platform];
+    }
+    if (options.workflow === Workflow.MANAGED) {
+      fingerprintOptions.ignorePaths = ['android/**/*', 'ios/**/*'];
+    }
+    if (options.debug) {
+      fingerprintOptions.debug = true;
+    }
+    const fingerprint = await Fingerprint.createFingerprintAsync(projectDir, fingerprintOptions);
+    spinner.succeed(`Computed project fingerprint`);
+    return fingerprint;
+  } catch (e) {
+    spinner.fail(`Failed to compute project fingerprint`);
+    Log.log('⏩ To skip this step, set the environment variable: EAS_SKIP_AUTO_FINGERPRINT=1');
+    throw e;
+  } finally {
+    // Clear the timeout if the operation finishes before the time limit
+    clearTimeout(timeoutId);
+    spinner.stop();
   }
-  // eslint-disable-next-line @typescript-eslint/return-await
-  return await Fingerprint.createFingerprintAsync(projectDir, fingerprintOptions);
 }