-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Create dynamic logged in context field and clean up erroneous SessionManager context field uses #2648
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @wschurman and the rest of your teammates on |
Size Change: -2.72 kB (-0.01%) Total Size: 53 MB
|
Subscribed to pull request
Generated by CodeMention |
8b5a873
to
503c451
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2648 +/- ##
==========================================
- Coverage 53.01% 53.01% -0.00%
==========================================
Files 566 567 +1
Lines 21637 21647 +10
Branches 4241 4242 +1
==========================================
+ Hits 11469 11474 +5
- Misses 10138 10143 +5
Partials 30 30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable
…us SessionManager context field uses
503c451
to
7bc0cb1
Compare
✅ Thank you for adding the changelog entry! |
Why
Noticed while reviewing another PR that the
config
command was using the session management context, when that context should only be necessary to use inlogin
andlogout
commands.Digging in a bit, it was needed because the command only required being logged in in a certain conditional codepath, but there was no context construct available to support this.
Ref: #2517
Ref: #2461
Closes ENG-13892.
How
DynamicLoggedIn
, which requires log in but only when the context function is called.config
command to use this.account:view
command.Test Plan
While both logged in and logged out: