-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-12793][eas-cli] make eas login
and eas whoami
behave more clearly when one is authenticated using EXPO_TOKEN
#2461
[ENG-12793][eas-cli] make eas login
and eas whoami
behave more clearly when one is authenticated using EXPO_TOKEN
#2461
Conversation
Size Change: -455 B (0%) Total Size: 52 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2461 +/- ##
==========================================
- Coverage 53.43% 53.41% -0.02%
==========================================
Files 530 530
Lines 19564 19577 +13
Branches 3979 3984 +5
==========================================
+ Hits 10453 10456 +3
- Misses 9089 9099 +10
Partials 22 22 ☔ View full report in Codecov by Sentry. |
} = await this.getContextAsync(AccountLogin, { nonInteractive: false }); | ||
|
||
if (sessionManager.getAccessToken()) { | ||
Log.warn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should just throw an error when eas login
is run when the EXPO_TOKEN
is set. Maybe say something like: "EXPO_TOKEN is set in your environment, and is being used for all EAS authentication. To use username/password authentication, unset EXPO_TOKEN in your environment and re-run the command.".
eas login
and eas whoami
behave more clearly when one is authenticated using EXPO_TOKEN
eas login
and eas whoami
behave more clearly when one is authenticated using EXPO_TOKEN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One wording change, otherwise lgtm.
Co-authored-by: Will Schurman <[email protected]>
✅ Thank you for adding the changelog entry! |
Why
Using
EXPO_TOKEN
seems confusing to people.#2460
How
When using the
eas whoami
command signal that a user is authenticated by usingEXPO_TOKEN
. It seems like people sometimes tend to forget that they haveEXPO_TOKEN
set, then they log in as a different account buteas whoami
still returns the same value because they are authed usingEXPO_TOKEN
and it seems to be confusing.Warn people when running
eas login
with theEXPO_TOKEN
set that this is not necessary.Test Plan
Test manually
eas whoami
after and beforeeas login