-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-10] [Wave Collect] [Xero] Build the Authorization flow #39725
Comments
Triggered auto assignment to @johncschuster ( |
|
@lakchote I'm not familiar with whether or not this can be built by an external contributor. Can you help me understand to whom I should triage this? |
@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue! |
@lakchote bump! Can I assign this one out to @SzymczakJ? |
Sorry I've just seen your message! Yes, this can be built by an external contributor, you can assign the issue to @SzymczakJ. Here is the Slack discussion for context, thank you! Also @SzymczakJ, please be aware of #39955 |
Assigned @SzymczakJ now @johncschuster as this PR is a critical one, since it's a requirement of the follow-up PRs for the different flows (Import, Export, Advanced). If we can gain time in making progress here, it'll be greatly beneficial for having momentum. Thank you for choosing to work on this. |
PR merged |
It has been deployed to staging and production, closing the issue. |
I realised my mistake after, and asked for confirmation with my mentor. Reopening the issue, that Payment date should be next Friday |
@mananjadhav, @johncschuster, @lakchote, @mountiny, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@johncschuster This is ready for payout for C+ review. |
This was a large PR and @mananjadhav helped to get this done urgently, I think we should pay them $500 for their thorough review @johncschuster |
Thanks @mountiny. Appreciate it. Quick question, this was deployed on production on May 01. Shouldn't it be ready for payout by now? |
Looks like we are at May 10 anyway. @johncschuster quick bump. |
Payment Summary
BugZero Checklist (@johncschuster)
|
Payment summary has been updated (Thanks for the incredible work, @mananjadhav and @SzymczakJ!). Please request $500 in NewDot, @mananjadhav! |
$500 approved for @mananjadhav |
You need to build the Xero authorization flow, following the steps outlined here.
Issue Owner
Current Issue Owner: @johncschusterThe text was updated successfully, but these errors were encountered: