Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-08] [Wave Collect] [Xero] Add Other Integrations and Xero section in the WorkspaceAccountingPage #39955

Closed
hayata-suenaga opened this issue Apr 9, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@hayata-suenaga
Copy link
Contributor

When adding support for Xero on the WorkspaceAccountingPage, do the following:

@hayata-suenaga hayata-suenaga added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 9, 2024
@hayata-suenaga hayata-suenaga moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Apr 9, 2024
Copy link

melvin-bot bot commented Apr 9, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@hayata-suenaga hayata-suenaga changed the title Add Other Integrations and Xero section in the WorkspaceAccountingPage [Wave Collect] [Xero] Add Other Integrations and Xero section in the WorkspaceAccountingPage Apr 9, 2024
@hayata-suenaga hayata-suenaga added Weekly KSv2 and removed Daily KSv2 Weekly KSv2 labels Apr 9, 2024
@hayata-suenaga hayata-suenaga added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 9, 2024
Copy link

melvin-bot bot commented Apr 9, 2024

@hayata-suenaga
Copy link
Contributor Author

We're just creating this issue so we don't forget this task when adding Xero support to New Expensify.

@lakchote lakchote self-assigned this Apr 10, 2024
@lakchote
Copy link
Contributor

cc @SzymczakJ since you'll work on the Authorization flow

@lakchote
Copy link
Contributor

Progress is still happening. This will be done in [Wave Collect] [Xero] Build the Authorization flow #39725

@melvin-bot melvin-bot bot removed the Overdue label Apr 19, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Weekly KSv2 labels Apr 19, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 19, 2024
Copy link

melvin-bot bot commented Apr 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 1, 2024
@melvin-bot melvin-bot bot changed the title [Wave Collect] [Xero] Add Other Integrations and Xero section in the WorkspaceAccountingPage [HOLD for payment 2024-05-08] [Wave Collect] [Xero] Add Other Integrations and Xero section in the WorkspaceAccountingPage May 1, 2024
Copy link

melvin-bot bot commented May 1, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 1, 2024
Copy link

melvin-bot bot commented May 1, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-08. 🎊

Copy link

melvin-bot bot commented May 1, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@lakchote] Please propose regression test steps to ensure the new feature will work correctly on production in further releases. - NA, it's not a regression.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon. - NA, there's no regression.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels May 7, 2024
Copy link

melvin-bot bot commented May 8, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Copy link

melvin-bot bot commented May 13, 2024

@lakchote Eep! 4 days overdue now. Issues have feelings too...

@lakchote
Copy link
Contributor

@hayata-suenaga should we close this?

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2024
@hayata-suenaga
Copy link
Contributor Author

@hayata-suenaga should we close this?

seems like the payment was handled in this issue. closing this now 👍

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants