Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-11] [Wave Collect] [Xero] [Advanced] Create the Purchase Bill Status Selector Page #39748

Closed
lakchote opened this issue Apr 5, 2024 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@lakchote
Copy link
Contributor

lakchote commented Apr 5, 2024

You need to build the page following the steps outlined here.

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0114d834a9c20463ee
  • Upwork Job ID: 1777087957833936896
  • Last Price Increase: 2024-04-07
Issue OwnerCurrent Issue Owner: @mallenexpensify
@lakchote lakchote added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 5, 2024
@lakchote lakchote moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
@mallenexpensify mallenexpensify added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Weekly KSv2 labels Apr 7, 2024
Copy link

melvin-bot bot commented Apr 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0114d834a9c20463ee

Copy link

melvin-bot bot commented Apr 7, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (Internal)

@mallenexpensify
Copy link
Contributor

Checking on in #bug-zero https://expensify.slack.com/archives/C01SKUP7QR0/p1712525687667159
Bumping to daily cuz it's #wave-collect and Release 1.

@jjcoffee would you be interested in building this?

@jjcoffee
Copy link
Contributor

jjcoffee commented Apr 8, 2024

@mallenexpensify In principle yes, but I have requested access to the doc so I can see the full scope. Also what sort of deadline would there be for this?

@mallenexpensify
Copy link
Contributor

@jjcoffee , hold for a moment. I think @lakchote is checking with some agency engineers who might be working on this.

@lakchote
Copy link
Contributor Author

Yes, agency engineers will work on this.

I've put this as a weekly first, since we won't be able to work on this until the Xero authorization flow is done.

It entails NewDot, Web-E, and IS changes (see DD details here).

Once this whole block is done, we'll be able to make progress here.

@mallenexpensify
Copy link
Contributor

Thanks @lakchote , going to leave 'as is' , just avoid adding External or else Help Wanted will get added and the job with open up to contributors

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@lakchote lakchote changed the title [Wave Collect] [Xero] [Advanced] Create the Purchase Bill Status Selector Page [HOLD #39746] [Wave Collect] [Xero] [Advanced] Create the Purchase Bill Status Selector Page Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

@mallenexpensify, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

@trjExpensify trjExpensify moved this from Release 1: Spring 2024 (May) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect Apr 16, 2024
@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Apr 17, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2024
@lakchote
Copy link
Contributor Author

lakchote commented Apr 19, 2024

Unassigning you @jjcoffee as this will be handled by internal or SWM engineers.

I might have internal engineers interested in this, I'm double-checking.

@mallenexpensify
Copy link
Contributor

Still holding

@trjExpensify
Copy link
Contributor

Draft PR is up.

@trjExpensify trjExpensify changed the title [HOLD #39746] [Wave Collect] [Xero] [Advanced] Create the Purchase Bill Status Selector Page [Wave Collect] [Xero] [Advanced] Create the Purchase Bill Status Selector Page May 9, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 10, 2024
Copy link

melvin-bot bot commented May 16, 2024

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@lakchote
Copy link
Contributor Author

Assigning @mananjadhav as he'll need to be paid for the C+ review of the linked PR once this hits production and the 7 day regression period passes.

@lakchote
Copy link
Contributor Author

Assigning @pecanoro as she has helped with reviewing the PR and providing translations.

@rushatgabhane
Copy link
Member

Xero issues are paid "centrally". We'll get a flat fee after all Xero related issues are closed.
No per issue pay required here.

@pecanoro
Copy link
Contributor

@rushatgabhane Including the C+?

@rushatgabhane
Copy link
Member

@pecanoro yes - @mananjadhav @hungvu193 and me

@pecanoro
Copy link
Contributor

Ok, then I think we can close this one, thank you guys!

@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect May 22, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 4, 2024
@melvin-bot melvin-bot bot changed the title [Wave Collect] [Xero] [Advanced] Create the Purchase Bill Status Selector Page [HOLD for payment 2024-06-11] [Wave Collect] [Xero] [Advanced] Create the Purchase Bill Status Selector Page Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 4, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

8 participants