Rebase 1.3.2 #8
Merged
Rebase 1.3.2 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed field `input` to new `inputs`. Addad Hash and Address as input types. Added bytes[N] and N validation
pkgsrc is a cross-platform package manager that also supports OS X.
crypto/secp256k1: add C compiler flags for pkgsrc
Infinite loop in filters
accounts/abi: ABI fixes & added types
eth, p2p, rpc/api: polish protocol info gathering
eth/downloader: fix dysfunctional ignore list hidden by generic set
tests: fix data race in bad-block-report disabling during tests
jsre: fix ethereum#1876, sleep too short on a slow test server
…race whisper: fix datarace in expiration test
cmd/geth: fix recover command crash if no param is supplied
eth: fix error casting regression during database open
event/filter: fix data race in the test
rpc/api: fix ethereum#1972 api regression (nil eth panic) in attach
cmd/geth, cmd/utils: surface the light KDF flag to the CLI
The C library treats the recovery ID as trusted input and crashes the process for invalid values, so it needs to be verified before calling into C. This will inhibit the crash in ethereum#1983. Also remove VerifySignature because we don't use it.
They cause compiler warnings for people who don't have these directories. People with pkgsrc can add the directory through CGO_CFLAGS instead.
Removed the legalese confirmation dialog. This closes ethereum#1992
Unexpected deliveries could block indefinitely if they arrived at the right time. The fix is to ensure that the cancellation channel is always closed when the sync ends, unblocking any deliveries. Also remove the atomic check for whether a sync is currently running because it doesn't help and can be misleading. Cancelling always seems to break the tests though. The downloader spawned d.process whenever new data arrived, making it somewhat hard to track when block processing was actually done. Fix this by running d.process in a dedicated goroutine that is tied to the lifecycle of the sync. d.process gets notified of new work by the queue instead of being invoked all the time. This removes a ton of weird workaround code, including a hairy use of atomic CAS.
State and receipt deliveries from a previous eth/62+ sync can hang if the downloader has moved on to syncing with eth/61. Fix this by also draining the eth/63 channels while waiting for eth/61 data. A nicer solution would be to take care of the channels in a central place, but that would involve a major rewrite.
eth/downloader: don't hang for spurious deliveries
…ccess core, eth, miner, xeth: clean up tx/receipt db accessors
cmd/geth, cmd/utils: removed legalese
eth/downloader: fetch data proportionally to peer capacity
…le-go Makefile: individual platforms, configurable Go runtime
rpc/api, xeth: added signTransaction method
Update common test files
miner: bugfix where blockhash in receipts and logs is left empty
Conflicts: VERSION cmd/geth/main.go
eth to exp
added new ones
thanhson1085
pushed a commit
to gitter-badger/go-hiverium
that referenced
this pull request
Jul 3, 2018
add validator voting smart contract
ldcc
added a commit
to gitter-badger/go-hiverium
that referenced
this pull request
Jul 30, 2018
optimization work mining
chrisfranko
pushed a commit
that referenced
this pull request
Mar 30, 2019
* added tests for new abi encoding features (#4) * added tests from bytes32[][] and string[] * added offset to other types * formatting * Abi/dynamic types (#5) * Revert "Abi/dynamic types (#5)" (#6) This reverts commit dabca31. * Abi/dynamic types (#7) * some cleanup * Apply suggestions from code review apply suggestions Co-Authored-By: vedhavyas <[email protected]> * added better formatting (#8) * review chnages * better comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the registrar