rpc/api: fix #1972 api regression (nil eth panic) in attach #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Fri Nov 6 10:21:45 UTC 2015 |
|
This fixes the problem. |
Current coverage is
|
|
👍 |
obscuren
added a commit
that referenced
this pull request
Nov 6, 2015
rpc/api: fix #1972 api regression (nil eth panic) in attach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peer info polish PR #1934 introduced a small regression during console attachment by calling a method on the local eth object (which does not exist) resulting in a nil panic. This was an unfortunate oversight that the object is nil during attach. This PR fixes that by moving the network accessing code back into the internals of the admin RPI API. This will be sorted out in a nicer way in the custom protocol stack PR, so it should be fine for now as a hotfix.