Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECR-1526 Prepare for maven release #298

Merged
merged 5 commits into from
Jun 15, 2018
Merged

ECR-1526 Prepare for maven release #298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
452901b
ECR-1526 Prepare for maven release
Jun 14, 2018
fb101f9
ECR-1526 Minor changes
Jun 15, 2018
7360383
ECR-1526 Move plugins from pluginManagement to plugins
Jun 15, 2018
15ec297
ECR-1526 Move maven-gpg-plugin to profile
Jun 15, 2018
9da08ee
Merge branch 'master' into ECR-1526
dmitry-timofeev Jun 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions exonum-java-binding-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<artifactId>exonum-java-binding-parent</artifactId>
<groupId>com.exonum.binding</groupId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wondering shouldn't we keep sync with core version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not at this point.

</parent>

<artifactId>exonum-java-binding-bom</artifactId>
Expand All @@ -17,8 +17,8 @@
<name>Exonum Java Binding: Bill of Materials</name>

<properties>
<exonum-core.version>1.0-SNAPSHOT</exonum-core.version>
<exonum-java-proofs.version>1.0-SNAPSHOT</exonum-java-proofs.version>
<exonum-core.version>0.1.0</exonum-core.version>
<exonum-java-proofs.version>0.1.0</exonum-java-proofs.version>
<guice.version>4.2.0</guice.version>
<log4j.version>2.11.0</log4j.version>
<guava.version>25.1-jre</guava.version>
Expand Down
11 changes: 7 additions & 4 deletions exonum-java-binding-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,17 @@
<parent>
<groupId>com.exonum.binding</groupId>
<artifactId>exonum-java-binding-parent</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
</parent>

<artifactId>exonum-java-binding-core</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
<packaging>jar</packaging>

<name>Exonum Java Binding: Core</name>
<description>
A library that contains the APIs to define and implement an Exonum service.
</description>

<properties>
<project.build.headersDirectory>${project.build.directory}/native-headers</project.build.headersDirectory>
Expand Down Expand Up @@ -236,7 +239,7 @@
<dependency>
<groupId>com.exonum.binding</groupId>
<artifactId>exonum-java-proofs</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
</dependency>

<dependency>
Expand Down Expand Up @@ -315,7 +318,7 @@
<dependency>
<groupId>com.exonum.binding</groupId>
<artifactId>exonum-java-testing</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
<scope>test</scope>
</dependency>

Expand Down
13 changes: 10 additions & 3 deletions exonum-java-binding-cryptocurrency-demo/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
<parent>
<artifactId>exonum-java-binding-parent</artifactId>
<groupId>com.exonum.binding</groupId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
</parent>
<modelVersion>4.0.0</modelVersion>
<packaging>jar</packaging>

<artifactId>exonum-java-binding-cryptocurrency-demo</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
<name>Exonum Java Binding: Cryptocurrency Java service</name>
<description>A simple cryptocurrency Exonum Java service.</description>

Expand All @@ -22,7 +22,7 @@
<gson.version>2.8.5</gson.version>
<protobuf.version>3.5.1</protobuf.version>
<exonum-bom.version>1.0.0</exonum-bom.version>
<exonum-java-testing.version>1.0-SNAPSHOT</exonum-java-testing.version>
<exonum-java-testing.version>0.1.0</exonum-java-testing.version>
</properties>

<build>
Expand Down Expand Up @@ -75,6 +75,13 @@
</execution>
</executions>
</plugin>

<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<configuration>
<skip>true</skip>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does such configuration excludes the module correctly (I remember you asked about this)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should. Tbh I'm not sure how to check it before our first deploy

</configuration>
</plugin>
</plugins>
</build>

Expand Down
13 changes: 10 additions & 3 deletions exonum-java-binding-fakes/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
<parent>
<artifactId>exonum-java-binding-parent</artifactId>
<groupId>com.exonum.binding</groupId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
</parent>

<modelVersion>4.0.0</modelVersion>

<artifactId>exonum-java-binding-fakes</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
<packaging>jar</packaging>

<name>Exonum Java Binding: Fakes</name>
Expand Down Expand Up @@ -66,14 +66,21 @@
</execution>
</executions>
</plugin>

<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

<dependencies>
<dependency>
<groupId>com.exonum.binding</groupId>
<artifactId>exonum-java-binding-core</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
</dependency>

<dependency>
Expand Down
11 changes: 9 additions & 2 deletions exonum-java-binding-qa-service/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
<parent>
<artifactId>exonum-java-binding-parent</artifactId>
<groupId>com.exonum.binding</groupId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
</parent>
<modelVersion>4.0.0</modelVersion>
<packaging>jar</packaging>

<artifactId>exonum-java-binding-qa-service</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
<name>Exonum Java Binding: QA Java service</name>
<description>A simple Exonum Java service for QA purposes.</description>

Expand Down Expand Up @@ -45,6 +45,13 @@
</argLine>
</configuration>
</plugin>

<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
6 changes: 4 additions & 2 deletions exonum-java-binding-service-archetype/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@
<parent>
<artifactId>exonum-java-binding-parent</artifactId>
<groupId>com.exonum.binding</groupId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
</parent>
<modelVersion>4.0.0</modelVersion>

<artifactId>exonum-java-binding-service-archetype</artifactId>
<packaging>maven-archetype</packaging>
<name>Exonum Service Maven Archetype: Quickstart</name>
<description>Archetype for creating Exonum Service application.</description>
<description>
Archetype for creating Exonum Service application.
</description>

<properties>
<maven-archetype.version>3.0.1</maven-archetype.version>
Expand Down
9 changes: 6 additions & 3 deletions exonum-java-proofs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,17 @@
<parent>
<groupId>com.exonum.binding</groupId>
<artifactId>exonum-java-binding-parent</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
</parent>

<artifactId>exonum-java-proofs</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
<packaging>jar</packaging>

<name>Exonum Java Binding: Proofs</name>
<description>
A library that provides classes to represent and verify Exonum proofs.
</description>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Expand Down Expand Up @@ -76,7 +79,7 @@
<dependency>
<groupId>com.exonum.binding</groupId>
<artifactId>exonum-java-testing</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
11 changes: 9 additions & 2 deletions exonum-java-testing/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
<parent>
<groupId>com.exonum.binding</groupId>
<artifactId>exonum-java-binding-parent</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
</parent>

<name>Exonum Java Binding: Testing Utils</name>
<artifactId>exonum-java-testing</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
<packaging>jar</packaging>

<build>
Expand All @@ -34,6 +34,13 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
</plugin>

<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
97 changes: 96 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,52 @@

<groupId>com.exonum.binding</groupId>
<artifactId>exonum-java-binding-parent</artifactId>
<version>1.0-SNAPSHOT</version>
<version>0.1.0</version>
<packaging>pom</packaging>

<name>Exonum Java Binding Parent</name>
<description>
The Exonum Java Binding library.
</description>
<url>https://github.com/exonum/exonum-java-binding</url>

<licenses>
<license>
<name>The Apache License, Version 2.0</name>
<url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
</license>
</licenses>

<organization>
<name>Exonum.com</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Exonum?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else? Bitfury?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I meant Exonum without the domain name for our website.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sure. I didn't know we have 'Exonum' organization.

<url>https://exonum.com/</url>
</organization>

<scm>
<connection>scm:git:https://github.com/exonum/exonum-java-binding.git</connection>
<developerConnection>scm:git:[email protected]:/exonum/exonum-java-binding.git</developerConnection>
<url>https://github.com/exonum/exonum-java-binding</url>
<tag>HEAD</tag>
</scm>

<distributionManagement>
<snapshotRepository>
<id>sonatype-nexus-snapshots</id>
<name>Sonatype Nexus Snapshots</name>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
</snapshotRepository>
<repository>
<id>sonatype-nexus-staging</id>
<name>Nexus Release Repository</name>
<url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url>
</repository>
</distributionManagement>

<issueManagement>
<system>github</system>
<url>https://github.com/exonum/exonum-java-binding/issues</url>
</issueManagement>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
Expand Down Expand Up @@ -126,13 +166,68 @@
<artifactId>versions-maven-plugin</artifactId>
<version>2.5</version>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.0.1</version>
<configuration>
<doclint>none</doclint>
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
<phase>deploy</phase>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>3.0.1</version>
<executions>
<execution>
<id>attach-sources</id>
<phase>deploy</phase>
<goals>
<goal>jar-no-fork</goal>
</goals>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
<version>2.8.2</version>
<executions>
<execution>
<id>default-deploy</id>
<phase>deploy</phase>
<goals>
<goal>deploy</goal>
</goals>
</execution>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it deploy to sonatype staging with no additional configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be enough for basic deploy

</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>1.6</version>
<executions>
<execution>
<id>sign-artifacts</id>
<phase>verify</phase>
<goals>
<goal>sign</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
Expand Down