ECR-1526 Prepare for maven release #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
reviewed
Jun 15, 2018
| @@ -7,7 +7,7 @@ | |||
| <parent> | |||
| <artifactId>exonum-java-binding-parent</artifactId> | |||
| <groupId>com.exonum.binding</groupId> | |||
| <version>1.0-SNAPSHOT</version> | |||
| <version>0.1.0</version> | |||
There was a problem hiding this comment.
I just wondering shouldn't we keep sync with core version?
There was a problem hiding this comment.
I think not at this point.
| <plugin> | ||
| <artifactId>maven-deploy-plugin</artifactId> | ||
| <configuration> | ||
| <skip>true</skip> |
There was a problem hiding this comment.
Does such configuration excludes the module correctly (I remember you asked about this)?
There was a problem hiding this comment.
It should. Tbh I'm not sure how to check it before our first deploy
pom.xml
Outdated
| </licenses> | ||
|
|
||
| <organization> | ||
| <name>Exonum.com</name> |
There was a problem hiding this comment.
What else? Bitfury?
There was a problem hiding this comment.
No, I meant Exonum without the domain name for our website.
There was a problem hiding this comment.
Ok, sure. I didn't know we have 'Exonum' organization.
pom.xml
Outdated
| <goals> | ||
| <goal>deploy</goal> | ||
| </goals> | ||
| </execution> |
There was a problem hiding this comment.
Does it deploy to sonatype staging with no additional configuration?
There was a problem hiding this comment.
Should be enough for basic deploy
|
|
Thanks, I moved these plugins to
I tested those at other phases - works well. Hopefully that won't change during
Well, we would be able to see what we are about to publish to Central after we deploy to our staging repo. I'm afraid there are not many more possibilities to test it. |
dmitry-timofeev
previously approved these changes
Jun 15, 2018
dmitry-timofeev
approved these changes
Jun 15, 2018
vitvakatu
pushed a commit
that referenced
this pull request
Jun 19, 2018
* Add third party licenses for direct Rust dependencies [ECR-1502]. (#277) * Update the project dependencies [ECR-1521, ECR-1518]: - Add versions plugin - Update the plugins that we use, specify the versions in the pluginManagement. - Update the versions of dependencies. - Disable Powermock tests until the library is updated. - Verify the project builds on 10, run tests with openjdk-10 on the CI server. - Check for updates on the CI server. * Use the default Java compiler instead of error-prone: Error-prone does not support Java 10 yet. A setup to activate it conditionally would be too verbose (a profile activation in each sub-module, because it does not work for <build><pluginManagement>...). See google/error-prone#860 * Do not install RocksDb — prevents SIGILL on older systems. On some systems with older CPUs our build produces an executable with an illegal instruction for those processors. The problem needs further investigation, but if we do not use the system version of RocksDb, it goes away. As I remember (have no stack at the moment), the illegal instruction appears somewhere in RocksDb initialization. See: ECR-1558 * Upgrade to Exonum 0.8 [ECR-1620] * Improve the documentation of a test. (#284) * Change Java serialization to protobuf and use owner’s public key as wallet id [ECR-1493, ECR-1494] - Change Java Serialization of transactions and wallets to protobuf. - Wallet String name is changed to the wallet owner’s public key. - Fix a bug in send money transaction when a transaction with the sender equal to the receiver resulted in doubling the balance of that wallet. PR: #272 * Messages payload length fix [ECR-1624]: 'payload length' field in the message header used to be equal to 'body' length in bytes, while it should be equal to the size of the whole message (header + body + signature). Also, improve the tests and exception messages. PR: #285 * Fix the service API path: (#288) The service API path must start with a slash to be correctly mounted. * Fix the transaction location URL [ECR-1648] (#293). The base path of explorer was changed in Exonum 0.7 from ""/api/system/v1" to "/api/explorer/v1/". * Add Javadoc plugin [ECR-1510] (#290): Javadoc generation does not happen during normal builds and must be triggered manually. JARs with the Javadoc for all modules can be generated with $ mvn javadoc:jar * Fix build on Travis CI [ECR-1658] (#292): * Build the dependencies instead of using installed in the system to prevent illegal instructions appearing in our artefacts (the actual cause is still unknown). * Disable caching of rust/target for it takes at least 2.5G, which is too much for Travis to archive and upload. * Add an Exonum App [ECR-869, ECR-867] (#238): Implemented JavaServiceRuntime abstraction around JVM to configure and run Java services. JavaServiceRuntime is a ServiceFactory, allowing to configure Java services in the same way as any other Exonum service. Also includes EJB App - a Rust application to configure and run an Exonum node with a specific Java service. * Add LICENSE and license headers in every source file [ECR-1499] (#295): Also added a script generating a text file with third-party licenses of Rust dependencies: ./generate_licenses.sh * Prepare the build configuration for a release [ECR-1526] (#298): Add required plugins to prepare artefacts for a publication to the repository. * Update native-proxies branch to Exonum 0.8.1 [ECR-1157] (#299). * Fix NodeProxy so that it can create a View * Remove 'provided' scope of the system dependencies of a service: (#301) Until we ship an app that includes these dependencies, they must be available on the classpath of the service (the only configuration option that we will have at 0.1 release). * Remove unused imports. * Use the Java home that Maven reports in the scripts setting LD_LIBRARY_PATH * Fix the Exception class that we use in tests: The mocked methods can not throw checked exceptions. * Skip all tests until the bug with loading shared libraries is fixed. * Add a tutorial describing how to launch a node with a Java service (#300) * Fix the application name and the script to start the crypto demo. * Update the project documents [ECR-486, ECR-1515, ECR-1516] (#296): Add a contribution guide, clean up the readme, add a roadmap. * Fix the formatting. * Fix anchors in the contribution guide. * Change travis-ci.com to travis-ci.org (#305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prepare for maven release.
See: https://jira.bf.local/browse/ECR-1526
Definition of Done