Fix the fetch-configlet script, which broke recently #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like Github has recently started returning non-uppercased HTTP headers, at least some of the time. This broke the script, which looked for a case-sensitive 'Location' header to find the newest version. This fixes the script such that it no longer cares whether the initial L is capital or not, and if it breaks again in the future, it will give a more informative error.
petertseng
approved these changes
Feb 28, 2020
workingjubilee
added a commit
to workingjubilee/c
that referenced
this pull request
Mar 19, 2020
Shamelessly dupes @coriolinus' fix: exercism/rust#929 "Looks like Github has recently started returning non-uppercased HTTP headers, at least some of the time. This broke the script, which looked for a case-sensitive 'Location' header to find the newest version. We can see this problem in spurious build failures like this." "This fixes the script such that it no longer cares whether the initial L is capital or not, and if it breaks again in the future, it will give a more informative error."
workingjubilee
added a commit
to workingjubilee/c
that referenced
this pull request
Mar 19, 2020
Shamelessly dupes @coriolinus' fix: exercism/rust#929 "Looks like Github has recently started returning non-uppercased HTTP headers, at least some of the time. This broke the script, which looked for a case-sensitive 'Location' header to find the newest version. We can see this problem in spurious build failures like this." "This fixes the script such that it no longer cares whether the initial L is capital or not, and if it breaks again in the future, it will give a more informative error."
ryanplusplus
pushed a commit
to exercism/c
that referenced
this pull request
Mar 19, 2020
* Fix fetch-configlet script Shamelessly dupes @coriolinus' fix: exercism/rust#929 "Looks like Github has recently started returning non-uppercased HTTP headers, at least some of the time. This broke the script, which looked for a case-sensitive 'Location' header to find the newest version. We can see this problem in spurious build failures like this." "This fixes the script such that it no longer cares whether the initial L is capital or not, and if it breaks again in the future, it will give a more informative error." * Add retry to fetch-configlet Riffing off of @glennj's fix exercism/bash#424 This fixes the problem by adding retries to the curl attempt, combined with the case-sensitivity fix. Also some of the logic has been reflowed. Most notably, we now dynamically check for what archive extension to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Github has recently started returning non-uppercased
HTTP headers, at least some of the time. This broke the script,
which looked for a case-sensitive 'Location' header to find the
newest version. We can see this problem in spurious build failures like this.
This fixes the script such that it no longer cares whether the initial
L is capital or not, and if it breaks again in the future, it will
give a more informative error.
Request relatively rapid review for this, given that we have an external PR which is broken pending this fix.