Scale generator README fixes #928
Conversation
The notes were being rendered in the same line, not in separate ones as originally intended. Signed-off-by: Rafael Fonseca <[email protected]>
Also add a definition in terms of steps to make it more clear. Signed-off-by: Rafael Fonseca <[email protected]>
|
Thanks for contributing this! The CI failure is at least partially not your fault; see #929 for details. You may need to rebase this PR once that one is merged. Still, CI will need to pass before we can consider merging. I note that in several instances you have added trailing whitespace at the end of lines. This may or may not be your fault. If the trailing whitespace derives from the problem specifications, CI will mandate that we include it. If it's something you added, you'll need to remove it. I haven't been tracking the state of the upstream specifications repo very closely, so I'm not sure whether or not this PR is tracking changes made there. If it is not, then we won't be able to merge this until the changes are also made there: CI ensures that the README files stay synchronized with those specifications. If it is in fact tracking changes there, you'll also need to update the version field in |
The trailing whitespaces are there to create a new line. If there is a better way to do that, let me know.
Oh I see. I'll send a PR against the problem-specifications repo then. |
The better way depends on your intent. In these cases, I'd probably go with unordered lists, personally. |
|
I see issue exercism/problem-specifications#1640 is already tracking the formatting and I created exercism/problem-specifications#1642 for the typo. I'm closing this PR. |
|
Oh, very good. Thanks for putting in this work! |
SSIA