triangle: Allow equilateral triangles to also be isosceles #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The triangle problem description says the following: > An isosceles triangle has at least two sides the same length. (It is > sometimes specified as having exactly two sides the same length, but > for the purposes of this exercise we'll say at least two.) However, previously the tests for this exercise only allowed isosceles triangles with exactly two sides of the same length. Removing the expectation that equilateral triangles must return false for `.is_isosceles()` allows students the freedom to decide which definition of "isosceles" they want to implement.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The triangle problem description says the following:
However, previously the tests for this exercise only allowed isosceles triangles with exactly two sides of the same length.
Removing the expectation that equilateral triangles must return false for
.is_isosceles()allows students the freedom to decide which definition of "isosceles" they want to implement.