Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangle: equilateral triangles are isosceles #228

Closed
clemensw opened this issue Nov 24, 2016 · 2 comments
Closed

Triangle: equilateral triangles are isosceles #228

clemensw opened this issue Nov 24, 2016 · 2 comments

Comments

@clemensw
Copy link

I agree the coding is more interesting, but I have a hard time accepting
assert!(triangle.is_equilateral());
assert!(!triangle.is_isosceles());

@petertseng
Copy link
Member

petertseng commented Nov 25, 2016

Given that exercism/problem-specifications#379 has been discussed and exercism/problem-specifications#424 has been merged as a result, we should resolve this issue by complying with the suite.

Re-visiting #206 would be a quick win in this area, though it may be worth it to rewrite the test suite follow the structure of the new JSON file.

@IanWhitney
Copy link
Contributor

Agreeing with @petertseng here. I think if you have an approach that you want to suggest, updating the official JSON file is the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants