Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResistorColorDuo: Remove unclear mention of "encoding" #972

Closed
wants to merge 1 commit into from

Conversation

joshgoebel
Copy link
Contributor

Encoding has a very specific meaning and using that word in the instructions was confusing and contradicts the test cases.

The test cases actually don't specify how "Brown" should be decoded at all.

Encoding has a very specific meaning and using that word in the instructions was confusing and contradicts the test cases.

The band colors are encoded as follows:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or one could leave this and just change the mappings below to all be lower-case.

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good... but it could be that this should be done in the exercism/problem-specifications repository. Specifically, this file.

@@ -6,9 +6,9 @@ If you want to build something using a Raspberry Pi, you'll probably use _resist
* Resistors are small - so small in fact that if you printed the resistance value on them, it would be hard to read.
To get around this problem, manufacturers print color-coded bands onto the resistors to denote their resistance values. Each band acts as a digit of a number. For example, if they printed a brown band (value 1) followed by a green band (value 5), it would translate to the number 15.

In this exercise, you are going to create a helpful program so that you don't have to remember the values of the bands. The program will take two colors as input, and output the correct number.
In this exercise, you are going to create a helpful program so that you don't have to remember the values of the bands. The program will take two colors as input, and output the resistance value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording may need to be changed in exercism/problem-specifications instead of on the track... I don't think it is specific to the track.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone confirms for sure that's what needs to be done and that we want this change I can do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the description is not track-specific, it needs to be done there ultimately. That said, I'm working on rewriting the description entirely. Are you okay with waiting for that? I'll make sure to ping you.
I'd like to wait until Jeremy is back before discussing it, because it's his description, and it's kind of an exemplar of what the product team wants in (future) exercise descriptions.
You okay with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it can wait a bit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS First things first: I will definitively include the removal of 'encoding' .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD.

@emcoding
Copy link
Contributor

I'm closing this, and I added the request to replace 'encoding' to exercism/problem-specifications#1471

@emcoding emcoding closed this Jul 23, 2019
@emcoding
Copy link
Contributor

Update: pr with the new description: exercism/problem-specifications#1561

@joshgoebel joshgoebel deleted the patch-3 branch September 25, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants