-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the story for ResistorColor #1471
Comments
I am currently working on a new description for the Resistor Color exercise and series. It's an examplar for how the Product Team wants in future exercise descriptions, as discussed with regard to Resistor Color Duo.* Please add your wishes/suggestions to the comments, so they can be taken into consideration for the rewrite. |
Previous suggestions for this exercise description:
|
See #1471 The current stories for Resistor Color and Resistor Color Duo raised some questions, as collected in the issue mentioned above. Recap of the wishlist: - Avoid the word 'encoding' - Don't make the listing of the color and its value look like a dictionary. - Make it more explicit that a color band has a numeric value _and_ a position. This commit is addressing these.
Discussion copied from the PR: @yyyc514 said:
@kotp answered:
"Not encourage" was what I was going for. Therefore I avoided to suggest either. I agree with @kotp, especially for the Ruby track. |
Such nuance. I follow the point, now I just think the spec/instructions themselves are made considerably WORSE by not including what was a very simple and useful mapping table - to help understand the issue (surely that's why it was included in the first place). The capitalization and "encoded" wording were issues for sure, but the table was a very useful part of the spec/instructions. I guess making the specs worse in service to the goal of discouraging a specific solution rubs me the wrong way a bit. I'm not sure there should be any good reasons to make the specs worse/less clear. |
The problem with the mapping table it that it completely hides the fact that there is more information than "colour -> number": the position of said colour. I proposed an entire table, but I also instantly said "this is probably too much information". I think that the latest iteration is a step towards the right direction, if not a pretty good near-final step. Note that the above says nothing about the data-structure. My suggestions were not based on students using hashes/objects or arrays/lists, but the fact that the mapping was incorrect. |
OK... How does removing the table improve this situation any? How does the replacement ordered list of colors address this at all? It seems you've identified a problem, but then that the changes we'd made don't truly address it at all. [other than the first early verbiage change a the top, but nothing about that necessitated changing the table] |
The current blob of text displayed for Resistor Color exercise (Introduction section as well as the README file) is this:
rather than the description found in the main repo: resistor-color/description.md |
@reddtoric which track? |
@SleeplessByte Woops, C# track |
You probably want to open an issue in https://github.com/exercism/csharp to sync their description with the canonical you found. |
For the C track I found the last test very confusing. It was very easy to map the mnemonics to an enum for the first 3 tests. But the last test has no signature for the Which invites people to look up solutions. |
This has been picked up in. |
The story of the second exercises in the series ( #1466 ) needed adjusting.
When that is sorted out, let’s use the lessons learned to improve on the existenting one.
The text was updated successfully, but these errors were encountered: