Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note on luhn description for single digits #492

Merged
merged 1 commit into from
Jan 15, 2017
Merged

Note on luhn description for single digits #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion exercises/luhn/description.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@ The task is to write a function that checks if a given string is valid.

Validating a Number
------
Strings of length 1 or less are not valid. Spaces are allowed in the input,
but they should be stripped before checking. All other non-digit characters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sentence makes me think of other cases: how about a string of only spaces?

However, it's not true that I would refuse to see this merged unless such a case was added. What do people think of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the space stripping is already tested, so that a spaces only test would be superfluous.

are disallowed.

As an example, here is a valid (but fictitious) Canadian Social Insurance
As an example of a valid string, here is a fictitious Canadian Social Insurance
Number.

```
Expand Down