Note on luhn description for single digits #492
Conversation
|
|
||
| As an example, here is a valid (but fictitious) Canadian Social Insurance | ||
| As an example of a valid string, here is fictitious Canadian Social Insurance |
There was a problem hiding this comment.
I think "is a" rather than just "is"
| @@ -7,8 +7,11 @@ The task is to write a function that checks if a given string is valid. | |||
|
|
|||
| Validating a Number | |||
| ------ | |||
| Strings of length 1 or less are not valid. Spaces are allowed in the input, | |||
| but they should be stripped before checking. All other non-digit characters | |||
There was a problem hiding this comment.
this sentence makes me think of other cases: how about a string of only spaces?
However, it's not true that I would refuse to see this merged unless such a case was added. What do people think of it?
There was a problem hiding this comment.
I think the space stripping is already tested, so that a spaces only test would be superfluous.
| "description": "single digit strings can not be valid", | ||
| "description": "zero length strings are not valid", | ||
| "input": "", | ||
| "expected": false |
There was a problem hiding this comment.
Is there an implementation that would return the wrong result for this case?
There was a problem hiding this comment.
Probably not, the single character test cases should cover this. I'm happy to remove this commit unless anyone else can think of an example...
A 0 or 1 length string is not valid, and nor is a string with non-space characters in.
stevejb71
force-pushed
the
NoteOnLuhnDescriptionForSingleDigits
branch
2 times, most recently
from
fbb71db to
2b9264e
Compare
|
Removed the commit containing an extra test for 0 length string. |
Add notes on edge cases for Luhn in the description, and add a 0 length string test.