-
-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http to https #2137
http to https #2137
Conversation
For all http links where an https equivalent would work, use the secure link in exercise metadata. For all JumpstartLab references I switched them to turing.edu since I was on the team at JumpstartLab at the time, and we were teaching at what became Turing School of Software and Design. (JumpstartLab's website doesn't handle https). There are a few links where I couldn't find an equivalent that resolved: - http://butunclebob.com/ArticleS.UncleBob.TheBowlingGameKata - http://claysnow.co.uk/recycling-tests-in-tdd/" - http://butunclebob.com/ArticleS.UncleBob.ThePrimeFactorsKata" - http://hyperphysics.phy-astr.gsu.edu/hbase/Organic/transcription.html - http://rubykoans.com
Using archive links might work, e.g. https://web.archive.org/web/20220408112140/http://hyperphysics.phy-astr.gsu.edu/hbase/Organic/transcription.html |
@SaschaMann that is an excellent idea. If I am not mistaken we already have a couple of those already. I will do that. |
Approved, even before the archive links are made. |
Ok, I think I got all of them. @ErikSchierboom Do you know if we have a link-checker set up for any of the repositories in the org to ensure we only link to HTTPS links? |
@kytrinyx I don't think we do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't visited all the new links, but I've checked that the remaining occurrences of http:
look good with this PR.
$ git rev-parse --short HEAD
77d58fdc
$ git grep --break --heading 'http:'
canonical-data.schema.json
25: "$schema": "http://json-schema.org/draft-04/schema#",
exercises/bowling/metadata.toml
4:source_url = "https://web.archive.org/web/20221001111000/http://butunclebob.com/ArticleS.UncleBob.TheBowlingGameKata"
exercises/change/metadata.toml
4:source_url = "https://web.archive.org/web/20130115115225/http://craftsmanship.sv.cmu.edu:80/exercises/coin-change-kata"
exercises/diamond/metadata.toml
4:source_url = "https://web.archive.org/web/20220807163751/http://claysnow.co.uk/recycling-tests-in-tdd/"
exercises/prime-factors/metadata.toml
4:source_url = "https://web.archive.org/web/20221026171801/http://butunclebob.com/ArticleS.UncleBob.ThePrimeFactorsKata"
exercises/rna-transcription/metadata.toml
4:source_url = "https://web.archive.org/web/20220408112140/http://hyperphysics.phy-astr.gsu.edu/hbase/Organic/transcription.html"
exercises/simple-linked-list/metadata.toml
4:source_url = "https://web.archive.org/web/20160731005714/http://brpreiss.com/books/opus8/html/page96.html"
exercises/triangle/metadata.toml
4:source_url = "https://web.archive.org/web/20220831105330/http://rubykoans.com"
I think the top one, in canonical-data.schema.json
, is correct because:
$ curl -sSf 'https://json-schema.org/draft-04/schema#' | jq -r '."$schema"'
http://json-schema.org/draft-04/schema#
Either way, I think that one doesn't block this PR. But a future CI https-link-checker should be sure not to error for it, if it's correct.
We could probably add the lychee action to the workflows for a link checker and require https. It is already used in a few repos. I'll open an issue for this and assign it to myself. |
The nth-prime exercise is inspired by problem 7 at Euler, not Problem 8. This got messed up in the http-to-https conversion in #2137.
The nth-prime exercise is inspired by problem 7 at Euler, not Problem 8. This got messed up in the http-to-https conversion in #2137.
For all http links where an https equivalent would work,
use the secure link in exercise metadata.
For all JumpstartLab references I switched them to turing.edu
since I was on the team at JumpstartLab at the time, and
we were teaching at what became Turing School of Software and
Design. (JumpstartLab's website doesn't handle https).
There are a few links where I couldn't find an equivalent
that resolved:
I would appreciate suggestions for what to use for these, as we could then
add link checking to ensure that all links are https.