-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sum-of-multiples: Mark as no longer under revision #209
Conversation
Hello, it's been a month. I think that's been quite ample notice. In a few hours, I would like to:
|
Updated plan: Instead, modify this PR to make the README say "This exercise is currently undergoing change, some tracks have defaults, some don't, if you want to help look at #198", then I'll merge. |
That was done in #236. So the above plan now should read:
|
This partially reverts 1f0ad90, which partially reverted 89308fd. The default behavior was added in #157 as a result of confusion in exercism/exercism#2654. Since then, we have decided the way forward is to remove the default behavior altogether, as discussed in #198. This commit should be held until all tracks have removed their expectations of default behavior.
@petertseng If I'm reading your comments correctly, we can merge this. Yes? |
No, I should have clarified. What was done was that #236 was merged. The comment that says "then I'll merge" applied to the PR that says "this exercise is undergoing change", which was #236. This PR here should only be merged after all tracks complete - currently clojure, cpp, and lfe have yet to do |
refactored generator to cater for two part problem names
This partially reverts 1f0ad90,
which partially reverted 89308fd.
The default behavior was added in #157 as a result of confusion in
exercism/exercism#2654. Since then, we have
decided the way forward is to remove the default behavior altogether, as
discussed in #198.
This commit should be held until all tracks have removed their
expectations of default behavior.