Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sum-of-multiples: Mark as no longer under revision #209

Merged
merged 1 commit into from
Aug 15, 2016
Merged

sum-of-multiples: Mark as no longer under revision #209

merged 1 commit into from
Aug 15, 2016

Conversation

petertseng
Copy link
Member

@petertseng petertseng commented Mar 23, 2016

This partially reverts 1f0ad90,
which partially reverted 89308fd.

The default behavior was added in #157 as a result of confusion in
exercism/exercism#2654. Since then, we have
decided the way forward is to remove the default behavior altogether, as
discussed in #198.

This commit should be held until all tracks have removed their
expectations of default behavior.

This was referenced Mar 23, 2016
@petertseng
Copy link
Member Author

Hello, it's been a month. I think that's been quite ample notice. In a few hours, I would like to:

  • Submit PRs to the remaining tracks myself
  • Not wait for them to merge those PRs, instead just merge this PR when I submit those

@petertseng
Copy link
Member Author

petertseng commented Apr 25, 2016

Updated plan: Instead, modify this PR to make the README say "This exercise is currently undergoing change, some tracks have defaults, some don't, if you want to help look at #198", then I'll merge.

@petertseng
Copy link
Member Author

petertseng commented Apr 29, 2016

That was done in #236. So the above plan now should read:

This partially reverts 1f0ad90,
which partially reverted 89308fd.

The default behavior was added in #157 as a result of confusion in
exercism/exercism#2654. Since then, we have
decided the way forward is to remove the default behavior altogether, as
discussed in #198.

This commit should be held until all tracks have removed their
expectations of default behavior.
@petertseng petertseng changed the title sum-of-multiples: Remove default behavior sum-of-multiples: Mark as no longer under revision Apr 29, 2016
@IanWhitney
Copy link
Contributor

@petertseng If I'm reading your comments correctly, we can merge this. Yes?

@petertseng
Copy link
Member Author

petertseng commented Jun 14, 2016

No, I should have clarified. What was done was that #236 was merged. The comment that says "then I'll merge" applied to the PR that says "this exercise is undergoing change", which was #236.

This PR here should only be merged after all tracks complete - currently clojure, cpp, and lfe have yet to do

@alebaffa alebaffa mentioned this pull request Aug 6, 2016
3 tasks
@petertseng petertseng merged commit 366abba into exercism:master Aug 15, 2016
@petertseng petertseng deleted the sum-of-multiples branch August 15, 2016 05:43
emcoding pushed a commit that referenced this pull request Nov 19, 2018
refactored generator to cater for two part problem names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants