Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Sum of Multiples exercise #198

Closed
3 tasks done
kytrinyx opened this issue Mar 12, 2016 · 6 comments
Closed
3 tasks done

Improve Sum of Multiples exercise #198

kytrinyx opened this issue Mar 12, 2016 · 6 comments

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Mar 12, 2016

See the discussions in exercism/exercism#2654 and exercism/go#256

There's been a bit of confusion due to the whole "defaults" thing (use 3 and 5 as defaults if no arguments are passed). I made that up sometime at the dawn of Exercism, and I regret it.

I would much rather have a cleaner problem statement with no defaults.

In order to fix this we would need to

  • clarify the README
  • create a canonical set of shared test inputs/outputs in sum-of-multiples.json
  • fix all of the existing implementations
This was referenced Mar 23, 2016
@alebaffa
Copy link

alebaffa commented Aug 6, 2016

Hi, is this exercise still under revision?
UPDATE: ok I found this comment on PR #209 👍

@kytrinyx
Copy link
Member Author

kytrinyx commented Aug 7, 2016

Yeah, if you look at all the related links in this thread, the issue needs to stay open as long as there are green badges:

screen shot 2016-08-07 at 9 11 02 am

@NobbZ
Copy link
Member

NobbZ commented Aug 12, 2016

I will try to tackle xlfe this weekend.

@NobbZ
Copy link
Member

NobbZ commented Aug 14, 2016

I took the freedom to tackle xlfe as well as xclojure.

But I am far from beeing an expert about the various lisp dialects and their different idioms, so building up the new testsuites was a very straightforward mechanical process, for sclojure, I even used 2 replace by regexp of my editor (against the lfe version) and I was ready to go in theory, but I fine tuned a little bit, because in the original suite there was used a zero? predicate instead of checking equality to 0

So both should be reviewed by track maintainers or track-VIPs at least.

@NobbZ
Copy link
Member

NobbZ commented Aug 14, 2016

Both got merged so it should be done now.

@petertseng
Copy link
Member

Great job, all involved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants