Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrabble is a trademark name. #1575

Merged
merged 1 commit into from
Aug 27, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions exercises/etl/canonical-data.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"exercise": "etl",
"version": "2.0.0",
"version": "2.0.1",
"cases": [
{
"comments": [
"Transforms a set of legacy scrabble data stored as letters per score",
"Transforms a set of legacy Scrabble data stored as letters per score",
"to a set of data stored score per letter.",
"Note: The expected input data for these tests should have",
"integer keys (not stringified numbers as shown in the JSON below",
Expand All @@ -18,8 +18,8 @@
"description": "single letter",
"property": "transform",
"input": {
"legacy": {
"1": ["A"]
"legacy": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, trailing whitespace is making noise... I can make this a separate commit, if anyone is having problems with it being included here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well of course. including a whitespace change in a commit whose commit message mentions Scrabble means that the commit message tells an untruth.

"1": ["A"]
}
},
"expected": {
Expand All @@ -30,7 +30,7 @@
"description": "single score with multiple letters",
"property": "transform",
"input": {
"legacy": {
"legacy": {
"1": ["A", "E", "I", "O", "U"]
}
},
Expand All @@ -46,7 +46,7 @@
"description": "multiple scores with multiple letters",
"property": "transform",
"input": {
"legacy": {
"legacy": {
"1": ["A", "E"],
"2": ["D", "G"]
}
Expand All @@ -62,7 +62,7 @@
"description": "multiple scores with differing numbers of letters",
"property": "transform",
"input": {
"legacy": {
"legacy": {
"1": ["A", "E", "I", "O", "U", "L", "N", "R", "S", "T"],
"2": ["D", "G"],
"3": ["B", "C", "M", "P"],
Expand Down
4 changes: 2 additions & 2 deletions exercises/etl/description.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ moaning about how stupid we could possibly be.)

### The goal

We're going to extract some scrabble scores from a legacy system.
We're going to extract some Scrabble scores from a legacy system.

The old system stored a list of letters per score:

Expand All @@ -23,7 +23,7 @@ The old system stored a list of letters per score:
- 8 points: "J", "X",
- 10 points: "Q", "Z",

The shiny new scrabble system instead stores the score per letter, which
The shiny new Scrabble system instead stores the score per letter, which
makes it much faster and easier to calculate the score for a word. It
also stores the letters in lower-case regardless of the case of the
input letters:
Expand Down
2 changes: 1 addition & 1 deletion exercises/scrabble-score/description.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Given a word, compute the scrabble score for that word.
Given a word, compute the Scrabble score for that word.

## Letter Values

Expand Down
2 changes: 1 addition & 1 deletion exercises/scrabble-score/metadata.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
---
blurb: "Given a word, compute the scrabble score for that word."
blurb: "Given a word, compute the Scrabble score for that word."
source: "Inspired by the Extreme Startup game"
source_url: "https://github.com/rchatley/extreme_startup"