-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrabble is a trademark name. #1575
Conversation
It was suggested that this change is good, but perhaps a little bit subtle. Should we mention that Scrabble is a game, or is the description suitably vague to encourage just a little bit of research? |
Then, you may also like to change some other instances of the uncapitalised word "scrabble".
of course, choosing not to do so wouldn't be grounds for refusing this PR, it would just be an indication that perhaps there is more work to be done. |
fb18b66
to
d9e9cca
Compare
Good idea, keeps it in line with the PR, and appropriate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not change the exercise name in the canonical-data.json “exercise” field. Several other exercises have proper names in that field (armstrong-numbers
and pascal-triangle
for example) and there’s no sense settings the precedent for a corporate trademark over a human person’s name. Plus this is used to map to a directory on the file system in at least one script I can think of, so this would end up forcing brittle case comparison and could cause real problems with case-sensitive file systems.
I was thinking it might be "sensitive". Thanks for the confirmation. |
d9e9cca
to
8621cfd
Compare
I think the changes elsewhere are good. It's a proper noun if nothing else, hence deserving of caps. |
Versioning on json is blocking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is now no substantive change to the canonical-data.json file could that be removed from the PR rather than have a whitespace-only change?
7a389a3
to
5bbf827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I believe this repo is still “locked” (see #1560) and this isn’t technically a bug fix change, but it’s now non-impactful and con-controversial, so should be okay to merge.
5bbf827
to
a938d89
Compare
It should be capitalized. It is also a noun, meaning a "doodle", and a verb, such as what this description could be considered. In our case, we are referring to the trademarked name of the game Scrabble. Signed-off-by: Victor Goff <[email protected]>
a938d89
to
ccbce72
Compare
@@ -18,8 +18,8 @@ | |||
"description": "single letter", | |||
"property": "transform", | |||
"input": { | |||
"legacy": { | |||
"1": ["A"] | |||
"legacy": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, trailing whitespace is making noise... I can make this a separate commit, if anyone is having problems with it being included here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well of course. including a whitespace change in a commit whose commit message mentions Scrabble means that the commit message tells an untruth.
It seems that only a version bump is necessary. Latest changes to this problem: - exercism/problem-specifications#1536 - exercism/problem-specifications#1575
It seems that only a version bump is necessary. Latest changes to this problem: - 1.0.0 to 1.0.1, descriptions too long: exercism/problem-specifications#1526 - 1.0.1 to 2.0.0, change input JSON format: exercism/problem-specifications#1536 - 2.0.0 to 2.0.1, capitalize Scrabble: exercism/problem-specifications#1575
Bump canonical test version from 2.0.0 to 2.0.1 This addresses exercism/problem-specifications#1575
It should be capitalized. It is also a noun, meaning a "doodle", and a verb, such as what this description could be considered.
In our case, we are referring to the trademarked name of the game Scrabble.