-
-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create exercise versioning policy based on Haskell track #628
Comments
@SleeplessByte For now I suggest not adding extra |
Sorry for not being clear with the issue description. Better late than never if anyone else ends up here. The issue here is not all exercises in this track are in sync with problem specifications. Some (if not most) lag behind and miss some tests or have old version of tests. We need to take this case by case basis and do the following:
I would expect separate PRs with a few exercises - not more than 3-4 in one PR so that it is easy to review. |
@tejasbubane yep! I'll make a checklist too. |
Can I have it please? 😄 |
@smb26 ❤️ of course. Could you start by opening another issue with at least the ones you're doing but preferably all the exercises as a checkbox (like I did with #600) and name it: #Checklist: add exercise versioning Note the steps are listed here: #628 (comment) |
@tejasbubane any update on the makefile change to remove the version / replace it with 0.0.0 when doing the integrity check (when running |
Haskell's versioning policy was decided in exercism/haskell#522, implemented in exercism/haskell#523 and documented in exercism/haskell#716. In particular, the main benefit of having a fourth serial version number is that you can track changes to any part of the exercise files given to a user. Having only the canonical version means you can keep the exercise up-to-date with canonical tests. |
Thank you for these links @sshine ! |
I was planning to add versions to |
I've started adding versions, because I can use the package.json in the test runner. Let's revisit this once that discussion is resolved, but use package.json for now. It will be trivial to move the version to whereever. |
We've dropped versions from canonical problem specs, so they don't make sense anymore in the context of this issue. |
Exercism tracking issue: https://github.com/exercism/exercism/issues/4786
Note: This is not the same as exercism/exercism#4266 which removed tracking versions from the user code.
Proposed implementation for JavaScript
In
package.json
change theversion
number to match thex.y.z
of test data versioning, and add.q
which we always increment if a change is made without a sync (new test data):x.y.z.q
.The text was updated successfully, but these errors were encountered: