Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checklist: drop eslint for exercises #620

Closed
4 tasks done
SleeplessByte opened this issue Feb 25, 2019 · 3 comments
Closed
4 tasks done

Checklist: drop eslint for exercises #620

SleeplessByte opened this issue Feb 25, 2019 · 3 comments
Assignees
@SleeplessByte
Labels
chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. good first issue help wanted

Comments

@SleeplessByte
Copy link
Member

SleeplessByte commented Feb 25, 2019 •
edited
Loading

Per #589,

  • move eslint config from root package.json into root .eslintrc
  • remove all eslint dependencies from exercise-level package.json
  • fix CI check to ignore eslint discrepancy between root and exercise-level package.json
  • (optional): add script to add eslint:recommended to exercise-level package.json on "deploy".
@SleeplessByte SleeplessByte added help wanted good first issue chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. labels Feb 25, 2019
This was referenced Mar 17, 2019
Closed
Closed
@ericrobinsondev
Copy link
Contributor

I'm happy to take this one, but I'm new to contributing so I'll need some direction on the third checkbox.

@SleeplessByte SleeplessByte self-assigned this Mar 23, 2019
@SleeplessByte
Copy link
Member Author

Hi @drericrobinson; this is in the works! However we could use a lot of help here.

@SleeplessByte
Copy link
Member Author

#645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SleeplessByte SleeplessByte

Labels
chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP Chore: integrity check without version, eslint per track and babel 7 exercism/javascript
2 participants
@SleeplessByte @ericrobinsondev