-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds additional test for two-fer exercise #733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) Thanks @m-a-ge I'll merge once the build passes
Ah this is failing because the example implementation needs to include the code needed to pass the new test |
Give me a sec, I'll try to fix it |
Per #728 (comment), wouldn't the expected output here be
? |
@stkent I think there was a bit of a confusion. Yes, If we are going by the fact that an empty string is a valid name then the expected output you gave would be correct |
@stkent, so, you want to see the following cases:
right? |
@m-a-ge correct, according to Katrina, that would be correct :) I would still place the empty string test last since it's a boundary case. |
in that case, I have to update the code accordingly and clear the history for the last two commits. |
ef53403
to
6065b40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good now
@Smarticles101, thanks! |
This should close #728
I've added additional test (as discussed) somewhat specific to
java
track and put it in the end of the file (even though this test doesn't present in canonical-data.json for this exercise)Reviewer Resources:
Track Policies