Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the empty unit test for the two-fer of the java track #1782

Closed
wants to merge 1 commit into from

Conversation

xinri
Copy link

@xinri xinri commented Nov 8, 2019


Reviewer Resources:

Track Policies

@xinri xinri force-pushed the two_fer_add_unit_tests branch from 8e95408 to ec2d04c Compare November 9, 2019 10:11
@xinri xinri force-pushed the two_fer_add_unit_tests branch from ec2d04c to c3731cb Compare November 9, 2019 10:15
@Smarticles101
Copy link
Member

Hey @exercism/java this has been discussed before. Hence my comment from exercism/exercism#5113

Java maintainer here 👋

In open source, it's worth it to check if an issue has come up in the past before. This has been brought up in multiple repos in including java.

Here's java/#733 (pr) and java/#728 (issue). The decision here was to treat the empty string as a name and output "One for , one for me." Personally, I agree with this decision under the basis that if a language can differentiate between an empty string and null, it should treat the empty string as a name as backed up in (problem-specifications/#290)[https://github.com/exercism/problem-specifications/issues/290#issuecomment-230727326].

My question is: should we revisit this? I'd like to get a feel for everyone's opinion on the matter.

@xinri xinri closed this Dec 5, 2019
@xinri
Copy link
Author

xinri commented Dec 5, 2019

I think it is better to drop this and keep the current behavior

@xinri xinri deleted the two_fer_add_unit_tests branch December 5, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants