Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roman-numerals: Change return type to a Maybe #328

Merged
merged 1 commit into from
Sep 20, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions exercises/roman-numerals/HINTS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
## Hints

To complete this exercise you need to implement the function `numerals`,
that *maybe* converts a number to a *string* representing a roman numeral.

Your function is expected to, at least, convert numbers up to 3000,
but is up to you to decide how far you want to go.
4 changes: 2 additions & 2 deletions exercises/roman-numerals/src/Example.hs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module Roman (numerals) where

numerals :: Int -> String
numerals = go numeralMap
numerals :: Int -> Maybe String
numerals = Just . go numeralMap
where
go pairs@((value, digits):pairs') n
| n >= value = digits ++ go pairs (n - value)
Expand Down
38 changes: 19 additions & 19 deletions exercises/roman-numerals/test/Tests.hs
Original file line number Diff line number Diff line change
Expand Up @@ -23,62 +23,62 @@ specs = describe "roman-numerals" $
-- Test cases adapted from `exercism/x-common/roman-numerals.json` on 2016-07-26.

data Case = Case { number :: Integer
, expected :: String
, expected :: Maybe String
}

cases :: [Case]
cases = [ Case { number = 1
, expected = "I"
, expected = Just "I"
}
, Case { number = 2
, expected = "II"
, expected = Just "II"
}
, Case { number = 3
, expected = "III"
, expected = Just "III"
}
, Case { number = 4
, expected = "IV"
, expected = Just "IV"
}
, Case { number = 5
, expected = "V"
, expected = Just "V"
}
, Case { number = 6
, expected = "VI"
, expected = Just "VI"
}
, Case { number = 9
, expected = "IX"
, expected = Just "IX"
}
, Case { number = 27
, expected = "XXVII"
, expected = Just "XXVII"
}
, Case { number = 48
, expected = "XLVIII"
, expected = Just "XLVIII"
}
, Case { number = 59
, expected = "LIX"
, expected = Just "LIX"
}
, Case { number = 93
, expected = "XCIII"
, expected = Just "XCIII"
}
, Case { number = 141
, expected = "CXLI"
, expected = Just "CXLI"
}
, Case { number = 163
, expected = "CLXIII"
, expected = Just "CLXIII"
}
, Case { number = 402
, expected = "CDII"
, expected = Just "CDII"
}
, Case { number = 575
, expected = "DLXXV"
, expected = Just "DLXXV"
}
, Case { number = 911
, expected = "CMXI"
, expected = Just "CMXI"
}
, Case { number = 1024
, expected = "MXXIV"
, expected = Just "MXXIV"
}
, Case { number = 3000
, expected = "MMM"
, expected = Just "MMM"
}
]