Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roman-numerals: Change return type to a Maybe #328

Merged
merged 1 commit into from
Sep 20, 2016
Merged

roman-numerals: Change return type to a Maybe #328

merged 1 commit into from
Sep 20, 2016

Conversation

rbasso
Copy link
Contributor

@rbasso rbasso commented Sep 20, 2016

  • Change test suite to expect a Maybe.
  • Add HINTS.md do explain what is expected in a solution.
  • Patch the example solution to return Just values.

Closes #304.

@rbasso
roman-numerals: Change return type to a Maybe
02aaccf 
- Change test suite to expect a `Maybe`.
- Add `HINTS.md` do explain what is expected in a solution.
- Patch the example solution to return `Just` values.
petertseng
petertseng approved these changes Sep 20, 2016
View reviewed changes
Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rbasso rbasso merged commit 91105df into exercism:master Sep 20, 2016
@rbasso rbasso deleted the roman-numerals-return-maybe branch September 20, 2016 07:02
@rbasso rbasso mentioned this pull request Dec 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertseng petertseng petertseng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbasso @petertseng