accumulate: update tests #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertseng
reviewed
Mar 6, 2017
| @@ -38,9 +38,7 @@ func TestAccumulate(t *testing.T) { | |||
| for _, test := range tests { | |||
| actual := Accumulate(test.given, test.converter) | |||
| if fmt.Sprintf("%s", actual) != fmt.Sprintf("%s", test.expected) { | |||
There was a problem hiding this comment.
I might say we have to use %q here too, otherwise for the first test (expects an empty list) someone could pass by emitting a list of many empty strings (not that I expect anyone to do that, but for completeness...?)
Or can switch to reflect.DeepEqual I suppose?
There was a problem hiding this comment.
Ah I'm wrong, many empty strings expands to [ ] which is different from []. So I guess the risk is someone might say ["echo echo echo echo"] instead of ["echo", "echo", "echo", "echo"]
There was a problem hiding this comment.
Ah, yes, that is possible.
see exercism#414 Also removed unnecessary else block
robphoenix
force-pushed
the
update/accumulate
branch
from
af16eaa to
2b0a4ef
Compare
|
now: |
petertseng
approved these changes
Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #414
Also removed unnecessary else block