Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configlet lint issues #1544

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Fix configlet lint issues #1544

merged 2 commits into from
Sep 13, 2021

Conversation

jmrunkle
Copy link
Contributor

Addresses the configlet lint issues from #1485

Namely: one missing slug and a bunch of empty author entries.

@jmrunkle jmrunkle marked this pull request as ready for review September 12, 2021 20:13
@jmrunkle jmrunkle mentioned this pull request Sep 12, 2021
@jmrunkle jmrunkle requested a review from ekingery September 12, 2021 20:14
Copy link
Contributor

@ekingery ekingery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Ideally the true author would be dug out of the commit history (assuming these are more than stub exercises), but I am approving because I think giving credit to @ErikSchierboom is better than having a broken build.

@jmrunkle
Copy link
Contributor Author

I did. The concepts are technically orthogonal to the exercises and the commits for the stuff in the concepts comes from Erik.

@jmrunkle jmrunkle merged commit 9aa06ed into exercism:main Sep 13, 2021
@jmrunkle jmrunkle deleted the configlet-lint branch September 13, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants