Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1485

Closed
ErikSchierboom opened this issue Aug 24, 2021 · 5 comments · Fixed by #1534
Closed

Fix CI #1485

ErikSchierboom opened this issue Aug 24, 2021 · 5 comments · Fixed by #1534
Assignees
Labels
x:action/fix Fix an issue x:knowledge/intermediate Quite a bit of Exercism knowledge required x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)

Comments

@ErikSchierboom
Copy link
Member

This repository's main branch currently does not pass all CI checks.
This makes detecting issues in PRs harder and might result in a broken track, and so is an important thing to fix.

The following CI workflows are currently failing:

https://github.com/exercism/go/runs/3382441936
https://github.com/exercism/go/runs/3382441888
https://github.com/exercism/go/runs/3382441808
https://github.com/exercism/go/runs/3382441775
https://github.com/exercism/go/runs/3382441694
https://github.com/exercism/go/runs/3382441690

Tracking

exercism/v3-launch#55

@ErikSchierboom ErikSchierboom added x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:knowledge/intermediate Quite a bit of Exercism knowledge required x:action/fix Fix an issue labels Aug 24, 2021
Hunk13 added a commit to Hunk13/go that referenced this issue Sep 11, 2021
@jmrunkle jmrunkle self-assigned this Sep 12, 2021
@jmrunkle
Copy link
Contributor

I will make sure this issue is taken care of. #1534 seems like a good start. I will make sure all of the CI issues are addressed before I close this. Still working on getting write access to this repo.

@jmrunkle
Copy link
Contributor

I believe there are still a few remaining issues with the CI.

Here are the errors from configlet:

The Concept Exercise `chessboard` has `range-iteration` in its `concepts`, which is not a `slug` in the top-level `concepts` array:
/home/runner/work/go/go/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/anonymous-functions/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/application-timing/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/bytes/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/channels/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/conditionals/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/context/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/defer/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/duration/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/empty-interface/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/floating-point/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/functions/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/goroutines/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/interfaces/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/iteration/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/mutex/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/nil/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/packages/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/panic/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/pointers/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/recover/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/reflection/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/runes/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/slices/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/type-assertion/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/type-conversion/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/variables/.meta/config.json

The `authors` array is empty:
/home/runner/work/go/go/concepts/zero-values/.meta/config.json

There are also a few more errors from the other ones, but I will start with making configlet lint happy.

@jmrunkle
Copy link
Contributor

PR #1544 fixes the configlet linting issues. Now I can start working on a PR to address other issues breaking the other CI tests.

@jmrunkle
Copy link
Contributor

Done, all CI are now passing on the main branch.

@iHiD
Copy link
Member

iHiD commented Sep 13, 2021

This is so great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/fix Fix an issue x:knowledge/intermediate Quite a bit of Exercism knowledge required x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants