-
-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pangram README claims input will only have ASCII #801
Comments
Going to keep the README but remove the non-ASCII compatible test entries. |
@tleen, I have not made it through all of the exercises yet. It would be good to have some of them show the capabilities of modern languages to in handling global inputs. I did not mind the Russian or German it was a good demonstration of not assuming English text. How many projects have we seen with the changelog entry "oh yeah, this ought to work outside of the US"? |
I agree, especially considering how go really works the rune concept over characters as they are known in any other language. It is one of the pain points and great strengths of the language. The way we addressed this specific issue is more or less to keep it consistent with the way this exercise is implemented across all all the Exercism tracks. It was decided that ASCII-only was the way to go here. We were an outlier. It is still a fairly early exercise in most tracks so that makes sense not to bring up character set issues just yet. Don't worry there are definitely exercises coming up with non-ASCII stuff. Runetime! |
Make sense. Sounds good. |
The README says:
There are German characters in one test which causes failures if not ignored or counted. But even then tests fail if code does not handle characters outside of ASCII. Specifically, Russian.
I am OK with having to check if a rune is ASCII or not. But the README explicitly says not to worry about it. Or is 'symbols' here meant to mean things other than letters like braces, emoji, and the like? Either way the README is at best not clear and at worst wrong.
The text was updated successfully, but these errors were encountered: