Skip to content

Commit

Permalink
pangram: Remove non-ASCII compatible test cases (#803)
Browse files Browse the repository at this point in the history
This brings the tests into consistency with the README.

Resolves #801, also see #802
  • Loading branch information
tleen authored Aug 15, 2017
1 parent 13e2ae5 commit 14919de
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion exercises/pangram/example.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"strings"
)

const testVersion = 1
const testVersion = 2

func IsPangram(s string) bool {
lowerString := strings.ToLower(s)
Expand Down
2 changes: 1 addition & 1 deletion exercises/pangram/pangram.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package pangram

const testVersion = 1
const testVersion = 2

func IsPangram(string) bool
4 changes: 1 addition & 3 deletions exercises/pangram/pangram_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"testing"
)

const targetTestVersion = 1
const targetTestVersion = 2

type testCase struct {
input string
Expand All @@ -20,8 +20,6 @@ var testCases = []testCase{
{"the 1 quick brown fox jumps over the 2 lazy dogs", true, ""},
{"7h3 qu1ck brown fox jumps ov3r 7h3 lazy dog", false, "missing letters replaced by numbers"},
{"\"Five quacking Zephyrs jolt my wax bed.\"", true, ""},
{"Victor jagt zwölf Boxkämpfer quer über den großen Sylter Deich.", true, ""},
{"Широкая электрификация южных губерний даст мощный толчок подъёму сельского хозяйства.", false, "Panagram in alphabet other than ASCII"},
}

func TestTestVersion(t *testing.T) {
Expand Down

0 comments on commit 14919de

Please sign in to comment.