Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises/practice/anagram: add an append with instructions about the order of the return values #1544

Closed
wants to merge 1 commit into from

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented Jan 15, 2025

No description provided.

Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?

Automated comment created by PR Commenter 🤖.

@neenjaw
Copy link
Contributor

neenjaw commented Jan 16, 2025

@IsaacG, Why this approach rather than change the test to not be dependent on the order?

@neenjaw
Copy link
Contributor

neenjaw commented Jan 16, 2025

I went digging to find the forum thread which prompted this PR, would have been nice to have more description with the motivation here. I don't think the order should matter, I will submit a candidate PR with a fixed test

@neenjaw neenjaw added the paused Work paused until further notice label Jan 16, 2025
@IsaacG
Copy link
Member Author

IsaacG commented Jan 16, 2025

Clarify what this track expects. Context: https://forum.exercism.org/t/14816/

@IsaacG
Copy link
Member Author

IsaacG commented Jan 16, 2025

I went digging to find the forum thread which prompted this PR, would have been nice to have more description with the motivation here. I don't think the order should matter, I will submit a candidate PR with a fixed test

You're absolutely correct. My apologies for the inconvenience. Would you like me to update this PR to reflect that the tests will not care about the order? Or this PR can be closed, leaving the instructions ambiguous and leaving it to the tests to impose (or not) any requirements.

@neenjaw
Copy link
Contributor

neenjaw commented Jan 19, 2025

closed in favor of PR

@neenjaw neenjaw closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paused Work paused until further notice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants