This repository has been archived by the owner on Jan 29, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 23
Add suggestions for Leap on Javascript #90
Open
MarcosX
wants to merge
2
commits into
exercism:master
Choose a base branch
from
MarcosX:js-leap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
### Reasonable solutions | ||
|
||
```javascript | ||
module.exports = { | ||
isLeap(year) { | ||
if (this.year % 4 !== 0) return false | ||
|
||
if (this.year % 100 !== 0) return true | ||
|
||
if (this.year % 100 === 0 && this.year % 400 === 0) return true | ||
|
||
return false | ||
} | ||
} | ||
``` | ||
|
||
### Common suggestions | ||
|
||
- For solutions that have more than one exit point, suggest trying to use a single | ||
exit point while maintaining legibility. It could be done by aggregating all | ||
conditionals in one and creating a temp var with a legible name for each. | ||
|
||
- Creating a helper function that checks if a number is divisible might also be | ||
a good idea. This would help with the first point and keep the logic readable. | ||
[Here is a good example of it](https://exercism.io/tracks/javascript/exercises/leap/solutions/caa4742c2be14884848044f9bcfbb775) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Like the example here, no if statement because the conditional statements can speak for themselves. |
||
|
||
### Talking points | ||
|
||
- Although this exercise is quite simple it is worth talking about the dangers of | ||
having functions with a lot of branching and specially when they lead to exit points. | ||
|
||
- If there is a boolean check that returns `true` or `false` then just returning the | ||
result of the boolean operation might achieve the same result. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a talking point would be that if statements that return true and false probably shouldn't because conditional statements are by definition true or false.