This repository has been archived by the owner on Jan 29, 2021. It is now read-only.
Add suggestions for Leap on Javascript #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzhen
reviewed
Oct 10, 2018
|
|
||
| - For solutions that have more than one exit point, suggest trying to use a single | ||
| exit point while maintaining legibility. It could be done by aggregating all | ||
| condintionals in one and creating a temp var with a legible name for each. |
kotp
reviewed
Oct 24, 2018
| if (this.year % 100 === 0 && this.year % 400 === 0) return true | ||
|
|
||
| return false | ||
| } |
There was a problem hiding this comment.
I think a talking point would be that if statements that return true and false probably shouldn't because conditional statements are by definition true or false.
kotp
reviewed
Oct 24, 2018
|
|
||
| - Creating a helper function that checks if a number is divisible might also be | ||
| a good idea. This would help with the first point and keep the logic readable. | ||
| [Here is a good example of it](https://exercism.io/tracks/javascript/exercises/leap/solutions/caa4742c2be14884848044f9bcfbb775) |
There was a problem hiding this comment.
Like the example here, no if statement because the conditional statements can speak for themselves.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Based on some solutions I've reviewed for Leap I summarized what I usually talk about and added here. Hope it helps!
Please let me know what you think.