Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added static keyword to static classes #215

Merged
merged 2 commits into from
Feb 28, 2017
Merged

Added static keyword to static classes #215

merged 2 commits into from
Feb 28, 2017

Conversation

tushartyagi
Copy link
Contributor

The following 5 exercises had only static methods but the classes were not static. Changes for the same.
Targets #207

@tushartyagi tushartyagi mentioned this pull request Feb 28, 2017
Closed
ErikSchierboom
ErikSchierboom requested changes Feb 28, 2017
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Would you mind also changing the example implementations (in the Example.cs file) for those problems to also use static classes?

@tushartyagi
Copy link
Contributor Author

@ErikSchierboom Done with changes.

@ErikSchierboom ErikSchierboom merged commit b52a761 into exercism:dotnet-core Feb 28, 2017
@ErikSchierboom
Copy link
Member

Thanks a lot @tushartyagi!

@ErikSchierboom ErikSchierboom mentioned this pull request Mar 31, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushartyagi @ErikSchierboom