-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use static classes where possible #207
Comments
@ErikSchierboom I can start working on this one. But this will also require changing the test cases and you are working on moving tests to xunit in #193 so it might be dependent on that. :) What are your thoughts? |
@tushartyagi There is indeed that xUnit dependency. You can work on this feature though, only you have to base your PR on the By the way, if you will be working on this, there are some exercises that currently have a constructor with one parameter and one single method being tested. I think that in most cases, those classes can be replaced with static classes, where the method being tested just gets an extra parameter. If you need any help, just contact me in the Gitter room. Thanks for the help! It is much appreciated. |
I have completed going through the exercises for classes which had:
Following is the list of exercises:
PR#215 submitted for this. |
@tushartyagi Brilliant! I've requested on small change in the PR. Thanks for looking into this! |
Some tests only require a static method to be present. If this is so, and if the implementation also only has static methods, we should convert the implementation to a static class.
The text was updated successfully, but these errors were encountered: