New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1854 play button click does not bubble into engine input #1926

Merged

eonarheim merged 2 commits into main from bugfix/1854-play-button-click

Jun 11, 2021

Member

eonarheim commented Jun 11, 2021

===:clipboard: PR Checklist :clipboard:===

📌 issue exists in github for these changes
🔬 existing tests still pass
🙈 code conforms to the style guide
📐 new tests written and passing / old tests updated with new scenario(s)
📄 changelog entry added (or not needed)

==================

Closes #1854

Changes:

Stop propagation on play button click

eonarheim added 2 commits

June 11, 2021 16:48


          fix: #1854 play button click does not bubble into engine input

02f8f15


          Add changelog

04d0698

eonarheim merged commit cf9b16b into main

eonarheim deleted the bugfix/1854-play-button-click branch

June 11, 2021 22:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet