Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Screen Logic to Support Independent Viewport and Resolution #1617

Closed
3 tasks
eonarheim opened this issue Aug 8, 2020 · 0 comments · Fixed by #1598
Closed
3 tasks

Refactor Screen Logic to Support Independent Viewport and Resolution #1617

eonarheim opened this issue Aug 8, 2020 · 0 comments · Fixed by #1598
Labels
core team This issue should be done by an Excalibur core member feature Label applied to new feature requests

Comments

@eonarheim
Copy link
Member

Context

The Screen does not have a convenient single place for logic to live.

Currently it is difficult build a game that has a different resolution than the viewport, this make it difficult to build lofi art style games. Additionally the current "Fullscreen" only means dynamic aspect ratio taking up the available window, there is now the browser Fullscreen API

Proposal

  • Refactor screen logic to one place
  • Support independent viewport/resolution controls
  • Support the browser fullscreen api
@eonarheim eonarheim added feature Label applied to new feature requests core team This issue should be done by an Excalibur core member labels Aug 8, 2020
@eonarheim eonarheim mentioned this issue Aug 8, 2020
Merged
5 tasks
eonarheim added a commit that referenced this issue Aug 8, 2020
@eonarheim
feat: [#1617] Screen Resolution Abstraction (#1598)
37f1a57 
Closes #1617 

## Changes:

- Refactors and creates a screen abstraction for managing all things resolution & viewport related logic
- Adds and fixes tests for the screen abstraction
@eonarheim eonarheim mentioned this issue Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core team This issue should be done by an Excalibur core member feature Label applied to new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Screen Resolution Abstraction excaliburjs/Excalibur
1 participant
@eonarheim