Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/257 mysql dialect #266

Merged
merged 10 commits into from
Sep 23, 2019
Merged

Feature/257 mysql dialect #266

merged 10 commits into from
Sep 23, 2019

Conversation

AnastasiiaSergienko
Copy link
Contributor

No description provided.

@AnastasiiaSergienko AnastasiiaSergienko added the feature Product feature label Sep 20, 2019
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Sep 20, 2019
@AnastasiiaSergienko AnastasiiaSergienko mentioned this pull request Sep 20, 2019
Closed
redcatbear
redcatbear requested changes Sep 20, 2019
View reviewed changes
Copy link
Collaborator

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with some small change requests. Good work you two!

doc/dialects/mysql.md Outdated Show resolved Hide resolved
doc/dialects/mysql.md Outdated Show resolved Hide resolved
...-jdbc-adapter/src/main/java/com/exasol/adapter/dialects/mysql/MySqlColumnMetadataReader.java Outdated Show resolved Hide resolved
...schema-jdbc-adapter/src/main/java/com/exasol/adapter/dialects/mysql/MySqlMetadataReader.java Outdated Show resolved Hide resolved
...tualschema-jdbc-adapter/src/main/java/com/exasol/adapter/dialects/mysql/MySqlSqlDialect.java Outdated Show resolved Hide resolved
...tualschema-jdbc-adapter/src/main/java/com/exasol/adapter/dialects/mysql/MySqlSqlDialect.java Outdated Show resolved Hide resolved
...tualschema-jdbc-adapter/src/main/java/com/exasol/adapter/dialects/mysql/MySqlSqlDialect.java Outdated Show resolved Hide resolved
...ter/virtualschema-jdbc-adapter/src/main/java/com/exasol/adapter/jdbc/JdbcAdapterFactory.java Outdated Show resolved Hide resolved
...ter/virtualschema-jdbc-adapter/src/main/java/com/exasol/adapter/jdbc/JdbcAdapterFactory.java Outdated Show resolved Hide resolved
@AnastasiiaSergienko AnastasiiaSergienko merged commit 7fcead9 into master Sep 23, 2019
@AnastasiiaSergienko AnastasiiaSergienko deleted the feature/257_mysql_dialect branch September 23, 2019 08:05
@AnastasiiaSergienko AnastasiiaSergienko mentioned this pull request Sep 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redcatbear redcatbear redcatbear approved these changes

Assignees

@AnastasiiaSergienko AnastasiiaSergienko

Labels
feature Product feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnastasiiaSergienko @redcatbear