Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for documentation #191

Closed
AnastasiiaSergienko opened this issue May 16, 2019 · 1 comment
Closed

Improvements for documentation #191

AnastasiiaSergienko opened this issue May 16, 2019 · 1 comment

Comments

@AnastasiiaSergienko
Copy link
Contributor

AnastasiiaSergienko commented May 16, 2019

I used new documentation and wrote down some things that were missing or that I would like to have:

Creating dialect part:

  1. I didn't find information about how to implement applyQuote method and SUPPORTED_PROPERTIES list.

Deploying adapter:

  1. It would be really nice to have a completed demo-example of registering adapter, connecting and creating VS somewhere in the documentation. Something similar to that one we used in the presentation.
  2. Remote logging is still quite hard to deal with. I didn't manage to start logging.

API

I found a few inaccuracies in the Virtual Schema API Documentation while using it.

Missing literal_interval json example here: https://github.com/exasol/virtual-schemas/tree/master/doc#literal

I discovered that "type": "predicate_equals" doesn't really work in our implementation, but "type": "predicate_equal" works fine. We need to fix the documentation or the implementation. You can find it here: https://github.com/exasol/virtual-schemas/tree/master/doc#predicates

The same for "predicate_notequals".

The same for "predicate_lessequals".

Missing predicate_is_null and predicate_is_not_null here: https://github.com/exasol/virtual-schemas/tree/master/doc#predicates

AnastasiiaSergienko added a commit that referenced this issue Sep 20, 2019
AnastasiiaSergienko added a commit that referenced this issue Sep 20, 2019
AnastasiiaSergienko added a commit that referenced this issue Sep 23, 2019
* #191: implemented MySQL dialect
* #257: changed the version to 2.1.0
AnastasiiaSergienko added a commit that referenced this issue Oct 8, 2019
AnastasiiaSergienko added a commit that referenced this issue Oct 8, 2019
* #191: improved documentation about creating a new dialect
@AnastasiiaSergienko
Copy link
Contributor Author

Unfinished part of the ticket moved to a new issue: #276
It will be finished on the new branch.
This issue will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant