-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for documentation #191
Comments
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 13, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 16, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 16, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 18, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 18, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 20, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 20, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 20, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 20, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 23, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Sep 30, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Oct 7, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Oct 8, 2019
AnastasiiaSergienko
added a commit
that referenced
this issue
Oct 8, 2019
* #191: improved documentation about creating a new dialect
Unfinished part of the ticket moved to a new issue: #276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I used new documentation and wrote down some things that were missing or that I would like to have:
Creating dialect part:
applyQuote
method andSUPPORTED_PROPERTIES
list.Deploying adapter:
API
I found a few inaccuracies in the Virtual Schema API Documentation while using it.
Missing literal_interval json example here: https://github.com/exasol/virtual-schemas/tree/master/doc#literal
I discovered that "type": "predicate_equals" doesn't really work in our implementation, but "type": "predicate_equal" works fine. We need to fix the documentation or the implementation. You can find it here: https://github.com/exasol/virtual-schemas/tree/master/doc#predicates
The same for "predicate_notequals".
The same for "predicate_lessequals".
Missing predicate_is_null and predicate_is_not_null here: https://github.com/exasol/virtual-schemas/tree/master/doc#predicates
The text was updated successfully, but these errors were encountered: