Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract base_model_udf.load_models into separate class #144

Closed
1 task
MarleneKress79789 opened this issue Oct 20, 2023 · 0 comments · Fixed by #161
Closed
1 task

Extract base_model_udf.load_models into separate class #144

MarleneKress79789 opened this issue Oct 20, 2023 · 0 comments · Fixed by #161
Assignees
@ahsimb @MarleneKress79789
Labels
refactoring

Comments

@MarleneKress79789
Copy link
Collaborator

Background:

  • Currently, we use from_pretrained with the cache_dir option to load the model and upload the cache directory to the BucketFS
  • The current approach in general works, but seems to check each time online if the model exists, we have access and we have the newest version
  • This is not possible in some deployments
  • To solve this issue, we could follow the following example using save_pretrained which stores the model into a directory which we then could upload
  • We can then load the model with from_pretrained from a local path
  • It would be easier to change the model loading once it is extracted into its own class

Acceptance Criteria
This was referenced Oct 20, 2023
Closed
Closed
@MarleneKress79789 MarleneKress79789 self-assigned this Nov 29, 2023
@MarleneKress79789 MarleneKress79789 mentioned this issue Dec 1, 2023
Merged
6 tasks
MarleneKress79789 added a commit that referenced this issue Dec 8, 2023
@MarleneKress79789
#144: Extracted load_models into seperate class (#161)
4629152 
* Moved model loader to separate class, injected into basemodel udf and changed test setup accordingly
* moved last_created_pipeline back
* security update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahsimb ahsimb

@MarleneKress79789 MarleneKress79789

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#144: Extracted load_models into seperate class exasol/transformers-extension
2 participants
@ahsimb @MarleneKress79789