Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use save_pretrained to make the model locally available #125

Closed
tkilias opened this issue Sep 1, 2023 · 2 comments
Closed

Use save_pretrained to make the model locally available #125

tkilias opened this issue Sep 1, 2023 · 2 comments
Assignees
Labels
feature New feature or request

Comments

@tkilias
Copy link
Collaborator

tkilias commented Sep 1, 2023

Background:

  • Currently, we use from_pretrained with the cache_dir option to load the model and upload the cache directory to the BucketFS
  • The current approach in general works, but seems to check each time online if the model exists, or we have access and if we have the newest version
  • This is not possible in some deployments
  • To solve this issue, we could follow the following example using save_pretrained which stores the model into a directory which we then could upload
  • We can then load the model with from_pretrained from a local path

Acceptance Criteria

  • Change download of model to save_pretrained
  • Upload the save model to the BucketFS
  • Use a local path to load the model during inference
@tkilias tkilias added bug Something isn't working feature New feature or request and removed bug Something isn't working labels Sep 1, 2023
@MarleneKress79789
Copy link
Collaborator

MarleneKress79789 commented Oct 18, 2023

suggested splitting of this ticket:

@MarleneKress79789 MarleneKress79789 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants