Unify ports for database, BucketFS, and SSH #354

ckunki · 2023-06-22T08:44:56Z

Closes #308
Closes #341

All Submissions:

Is the title of the Pull Request correct?
Is the title of the corresponding issue correct?
Have you updated the changelog?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Are you mentioning the issue which this PullRequest fixes ("Fixes...")
Before you merge don't forget to run all tests for all Exasol version, by adding [run all tests] to the commit message
Are the CLI usage examples up to date?

eitde/test/test_test_env_reuse.py uses Ports.random_free() now removed Ports.docker removed dead code and open questions

docker_db_config_template/8.17.0/EXAConf

docker_db_config_template/7.0.0/EXAConf

exasol_integration_test_docker_environment/lib/test_environment/spawn_test_database.py

pytest_itde/__init__.py

…ution

ssh port is already available in DatabaseInfo.ports.ssh

exasol_integration_test_docker_environment/lib/test_environment/spawn_test_database.py

exasol_integration_test_docker_environment/testing/api_test_environment.py

pytest_itde/__init__.py

docker_db_config_template/8.18.1/EXAConf

test/integration/pytest_itde_test.py

Co-authored-by: Torsten Kilias <[email protected]>

…/docker_db_config

ckunki added 7 commits June 22, 2023 10:20

initial implementation

b9ca0fe

Annotated properties of class Ports with references to usages

975f8ac

Updated changes_2.0.0.md

c1b5d18

Replaced ports in EXAConf by template variables

482219a

fixed errors in pytest_plugin_itde_test.py

a52f516

Removed Exposed ports from files EXAConf

4b166de

reviewed and cleaned up references to class Port

a4bbce0

eitde/test/test_test_env_reuse.py uses Ports.random_free() now removed Ports.docker removed dead code and open questions

tkilias mentioned this pull request Jun 23, 2023

308: Changed DB port #340

Closed

7 tasks

ckunki requested a review from tkilias June 23, 2023 12:44

tkilias requested changes Jun 23, 2023

View reviewed changes

ckunki added 6 commits June 23, 2023 16:14

added ssh_port to all EXAConf templates and enhanced template substit…

344f515

…ution

Fixed review findings

37a2f59

Added forwarded ports to DatabaseInfo

fcd251a

Removed port from ShInfo

adbfd09

ssh port is already available in DatabaseInfo.ports.ssh

fixed Test

82861fb

fixed test/integration/pytest_itde_test.py

7f8ad18

tkilias requested changes Jun 27, 2023

View reviewed changes

Fixed review findings

8fb0b08

ckunki mentioned this pull request Jun 27, 2023

Add additional tests for pytest_itde #357

Closed

ckunki requested a review from tkilias June 27, 2023 08:56

ckunki added 2 commits June 27, 2023 13:39

Fixed tests

282b979

made moved forwarded port an attribute of class SpawnTestDockerDatabase

4b4679f

tkilias previously approved these changes Jun 27, 2023

View reviewed changes

ckunki and others added 2 commits June 27, 2023 14:47

[run all tests]

ec773f1

Use EXASOL_VERSION in pytest_itde_test.py [run all tests]

5415844

tkilias dismissed their stale review via 5415844 June 28, 2023 10:55

ckunki added 4 commits June 29, 2023 09:44

set log level for debugging purposes

c6d4243

[run all tests]

a121b61

added workflow for manual experiments

35103c8

added on: workflow_dispatch:

09b11ba

ckunki added 10 commits June 29, 2023 15:05

changed noxfile

9bfd3af

fixed noxfile.py

ab3a5df

CLeaned up tests

ab1fcf8

removed experimental test

d7e6c9d

[run all tests]

cf67beb

added env to noxfile

820ce1b

experimental

5d0c96a

added unit tests and old tests based on python lib "unittest"

6c64352

finalized noxfile

84ffc38

[run all tests]

9fb77b0

ckunki mentioned this pull request Jul 3, 2023

ITDE: Unify ports for database, BucketFS, and SSH #308

Closed

tkilias requested changes Jul 3, 2023

View reviewed changes

docker_db_config_template/8.18.1/EXAConf Outdated Show resolved Hide resolved

test/integration/pytest_itde_test.py Outdated Show resolved Hide resolved

Update test/integration/pytest_itde_test.py

eac0c59

Co-authored-by: Torsten Kilias <[email protected]>

ckunki requested a review from tkilias July 3, 2023 08:48

ckunki added 13 commits July 3, 2023 10:54

removed commented lines in 8.18.1/EXAConf

07575e5

[run all tests]

2c33cee

re-activated new integration tests

20f4898

added build script for experimental tests

66442a7

fixed build script

30808e9

added chroot for 8.17.0/EXAConf as well

de76d4d

changed COS version in path to sbin/nsexec_chroot to match ConfVersion

180a9c6

copied EXAConf template to exasol_integration_test_docker_environment…

1082e82

…/docker_db_config

[run all tests]

e863e24

removed experimental workflow

27f0c34

[run all tests]

1424cc1

Fixed build matrix

f66f715

[run all tests]

b024bdc

tkilias approved these changes Jul 4, 2023

View reviewed changes

ckunki merged commit 390968a into main Jul 4, 2023

ckunki deleted the feature/308-default-ports branch July 4, 2023 08:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unify ports for database, BucketFS, and SSH #354

Unify ports for database, BucketFS, and SSH #354

ckunki commented Jun 22, 2023 •

edited

Loading

Unify ports for database, BucketFS, and SSH #354

Unify ports for database, BucketFS, and SSH #354

Conversation

ckunki commented Jun 22, 2023 • edited Loading

All Submissions:

ckunki commented Jun 22, 2023 •

edited

Loading